Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect atypes on various eids #6477

Merged
merged 11 commits into from
Mar 29, 2021
Merged

Incorrect atypes on various eids #6477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c2f2046
Update eids.js
patmmccann Mar 25, 2021
c422dc9
Update eids_spec.js
patmmccann Mar 25, 2021
ec752ee
Update eids.js
patmmccann Mar 25, 2021
ea44e21
Update pubmaticBidAdapter_spec.js
patmmccann Mar 25, 2021
d44f298
Update eids.js
patmmccann Mar 25, 2021
10efcdd
Update eids_spec.js
patmmccann Mar 25, 2021
78fb35f
Update conversantBidAdapter_spec.js
patmmccann Mar 25, 2021
5c082a1
Update rubiconBidAdapter_spec.js
patmmccann Mar 25, 2021
09741b0
Update conversantBidAdapter_spec.js
patmmccann Mar 25, 2021
f42f6d8
Delete test/spec/adapters directory
patmmccann Mar 25, 2021
35de176
Update userId_spec.js
patmmccann Mar 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions modules/userId/eids.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ const USER_IDS_CONFIG = {
// identityLink
'idl_env': {
source: 'liveramp.com',
atype: 1
atype: 3
},

// liveIntentId
Expand All @@ -80,7 +80,7 @@ const USER_IDS_CONFIG = {
return data.lipbid;
},
source: 'liveintent.com',
atype: 1,
atype: 3,
getEidExt: function(data) {
if (Array.isArray(data.segments) && data.segments.length) {
return {
Expand All @@ -93,7 +93,7 @@ const USER_IDS_CONFIG = {
// britepoolId
'britepoolid': {
source: 'britepool.com',
atype: 1
atype: 3
},

// lotamePanoramaId
Expand All @@ -111,7 +111,7 @@ const USER_IDS_CONFIG = {
// merkleId
'merkleId': {
source: 'merkleinc.com',
atype: 1
atype: 3
},

// NetId
Expand Down Expand Up @@ -161,7 +161,7 @@ const USER_IDS_CONFIG = {
// Verizon Media ConnectID
'connectid': {
source: 'verizonmedia.com',
atype: 1
atype: 3
},

// Neustar Fabrick
Expand Down
Empty file removed test/spec/adapters/adbutler_spec.js
View file
Open in desktop
Empty file.
2 changes: 1 addition & 1 deletion test/spec/modules/conversantBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ describe('Conversant adapter tests', function() {
const payload = spec.buildRequests(requests).data;
expect(payload).to.have.deep.nested.property('user.ext.eids', [
{source: 'adserver.org', uids: [{id: '223344', atype: 1, ext: {rtiPartner: 'TDID'}}]},
{source: 'liveramp.com', uids: [{id: '334455', atype: 1}]}
{source: 'liveramp.com', uids: [{id: '334455', atype: 3}]}
]);
});
});
Expand Down
10 changes: 5 additions & 5 deletions test/spec/modules/eids_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ describe('eids array generation for known sub-modules', function() {
expect(newEids.length).to.equal(1);
expect(newEids[0]).to.deep.equal({
source: 'merkleinc.com',
uids: [{id: 'some-random-id-value', atype: 1}]
uids: [{id: 'some-random-id-value', atype: 3}]
});
});

Expand All @@ -102,7 +102,7 @@ describe('eids array generation for known sub-modules', function() {
expect(newEids.length).to.equal(1);
expect(newEids[0]).to.deep.equal({
source: 'liveramp.com',
uids: [{id: 'some-random-id-value', atype: 1}]
uids: [{id: 'some-random-id-value', atype: 3}]
});
});

Expand All @@ -117,7 +117,7 @@ describe('eids array generation for known sub-modules', function() {
expect(newEids.length).to.equal(1);
expect(newEids[0]).to.deep.equal({
source: 'liveintent.com',
uids: [{id: 'some-random-id-value', atype: 1}],
uids: [{id: 'some-random-id-value', atype: 3}],
ext: {segments: ['s1', 's2']}
});
});
Expand All @@ -132,7 +132,7 @@ describe('eids array generation for known sub-modules', function() {
expect(newEids.length).to.equal(1);
expect(newEids[0]).to.deep.equal({
source: 'liveintent.com',
uids: [{id: 'some-random-id-value', atype: 1}]
uids: [{id: 'some-random-id-value', atype: 3}]
});
});

Expand All @@ -144,7 +144,7 @@ describe('eids array generation for known sub-modules', function() {
expect(newEids.length).to.equal(1);
expect(newEids[0]).to.deep.equal({
source: 'britepool.com',
uids: [{id: 'some-random-id-value', atype: 1}]
uids: [{id: 'some-random-id-value', atype: 3}]
});
});

Expand Down
6 changes: 3 additions & 3 deletions test/spec/modules/pubmaticBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1695,7 +1695,7 @@ describe('PubMatic adapter', function () {
'source': 'liveramp.com',
'uids': [{
'id': 'identity-link-user-id',
'atype': 1
'atype': 3
}]
}]);
});
Expand Down Expand Up @@ -1736,7 +1736,7 @@ describe('PubMatic adapter', function () {
'source': 'liveintent.com',
'uids': [{
'id': 'live-intent-user-id',
'atype': 1
'atype': 3
}]
}]);
});
Expand Down Expand Up @@ -1818,7 +1818,7 @@ describe('PubMatic adapter', function () {
'source': 'britepool.com',
'uids': [{
'id': 'britepool-user-id',
'atype': 1
'atype': 3
}]
}]);
});
Expand Down
4 changes: 2 additions & 2 deletions test/spec/modules/rubiconBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1498,15 +1498,15 @@ describe('the rubicon adapter', function () {
// LiveIntent should exist
expect(post.user.ext.eids[0].source).to.equal('liveintent.com');
expect(post.user.ext.eids[0].uids[0].id).to.equal('0000-1111-2222-3333');
expect(post.user.ext.eids[0].uids[0].atype).to.equal(1);
expect(post.user.ext.eids[0].uids[0].atype).to.equal(3);
expect(post.user.ext.eids[0]).to.have.property('ext').that.is.an('object');
expect(post.user.ext.eids[0].ext).to.have.property('segments').that.is.an('array');
expect(post.user.ext.eids[0].ext.segments[0]).to.equal('segA');
expect(post.user.ext.eids[0].ext.segments[1]).to.equal('segB');
// LiveRamp should exist
expect(post.user.ext.eids[1].source).to.equal('liveramp.com');
expect(post.user.ext.eids[1].uids[0].id).to.equal('1111-2222-3333-4444');
expect(post.user.ext.eids[1].uids[0].atype).to.equal(1);
expect(post.user.ext.eids[1].uids[0].atype).to.equal(3);
// SharedId should exist
expect(post.user.ext.eids[2].source).to.equal('sharedid.org');
expect(post.user.ext.eids[2].uids[0].id).to.equal('1111');
Expand Down
16 changes: 8 additions & 8 deletions test/spec/modules/userId_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -938,7 +938,7 @@ describe('User ID', function () {
expect(bid.userId.idl_env).to.equal('AiGNC8Z5ONyZKSpIPf');
expect(bid.userIdAsEids[0]).to.deep.equal({
source: 'liveramp.com',
uids: [{id: 'AiGNC8Z5ONyZKSpIPf', atype: 1}]
uids: [{id: 'AiGNC8Z5ONyZKSpIPf', atype: 3}]
});
});
});
Expand All @@ -962,7 +962,7 @@ describe('User ID', function () {
expect(bid.userId.idl_env).to.equal('AiGNC8Z5ONyZKSpIPf');
expect(bid.userIdAsEids[0]).to.deep.equal({
source: 'liveramp.com',
uids: [{id: 'AiGNC8Z5ONyZKSpIPf', atype: 1}]
uids: [{id: 'AiGNC8Z5ONyZKSpIPf', atype: 3}]
});
});
});
Expand Down Expand Up @@ -1032,7 +1032,7 @@ describe('User ID', function () {
expect(bid.userId.lipb.lipbid).to.equal('random-ls-identifier');
expect(bid.userIdAsEids[0]).to.deep.equal({
source: 'liveintent.com',
uids: [{id: 'random-ls-identifier', atype: 1}]
uids: [{id: 'random-ls-identifier', atype: 3}]
});
});
});
Expand All @@ -1056,7 +1056,7 @@ describe('User ID', function () {
expect(bid.userId.lipb.lipbid).to.equal('random-cookie-identifier');
expect(bid.userIdAsEids[0]).to.deep.equal({
source: 'liveintent.com',
uids: [{id: 'random-cookie-identifier', atype: 1}]
uids: [{id: 'random-cookie-identifier', atype: 3}]
});
});
});
Expand Down Expand Up @@ -1440,7 +1440,7 @@ describe('User ID', function () {
expect(bid.userId.lipb.segments).to.include('123');
expect(bid.userIdAsEids[0]).to.deep.equal({
source: 'liveintent.com',
uids: [{id: 'random-ls-identifier', atype: 1}],
uids: [{id: 'random-ls-identifier', atype: 3}],
ext: {segments: ['123']}
});
});
Expand Down Expand Up @@ -1469,7 +1469,7 @@ describe('User ID', function () {
expect(bid.userId.lipb.segments).to.include('123');
expect(bid.userIdAsEids[0]).to.deep.equal({
source: 'liveintent.com',
uids: [{id: 'random-cookie-identifier', atype: 1}],
uids: [{id: 'random-cookie-identifier', atype: 3}],
ext: {segments: ['123']}
});
});
Expand All @@ -1494,7 +1494,7 @@ describe('User ID', function () {
expect(bid.userId.britepoolid).to.equal('279c0161-5152-487f-809e-05d7f7e653fd');
expect(bid.userIdAsEids[0]).to.deep.equal({
source: 'britepool.com',
uids: [{id: '279c0161-5152-487f-809e-05d7f7e653fd', atype: 1}]
uids: [{id: '279c0161-5152-487f-809e-05d7f7e653fd', atype: 3}]
});
});
});
Expand Down Expand Up @@ -1592,7 +1592,7 @@ describe('User ID', function () {
expect(bid.userId.merkleId).to.equal('testmerkleId');
expect(bid.userIdAsEids[0]).to.deep.equal({
source: 'merkleinc.com',
uids: [{id: 'testmerkleId', atype: 1}]
uids: [{id: 'testmerkleId', atype: 3}]
});
});
});
Expand Down