Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inmar bidder adapter: Make adNetId an optional paramater #6136

Merged
merged 14 commits into from
Dec 18, 2020
Merged

Inmar bidder adapter: Make adNetId an optional paramater #6136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ced7cb7
Add Inmar bidder adapter
zandree-owneriq Jul 8, 2020
36726b9
Update Inmar adapter
zandree-owneriq Aug 6, 2020
bd58f8e
Small fix
zandree-owneriq Aug 20, 2020
51c3b2d
Update Inmar params
zandree-owneriq Aug 28, 2020
7436a90
Remove domain and bidFloor, add meta
zandree-owneriq Aug 31, 2020
014c39b
Remove unused data
zandree-owneriq Aug 31, 2020
4d07cd0
Fix unit tests
zandree-owneriq Sep 1, 2020
3527576
Merge commit 'bfb182a47cd2cce1fb7fbfe73513090786515b02'
zandree-owneriq Sep 16, 2020
43573fd
Merge commit '05a5a969b8f3a679308c3546386565838ae472d7'
zandree-owneriq Sep 25, 2020
a8b2ef0
Update Inmar bidder adapter
zandree-owneriq Dec 17, 2020
79225bd
Merge commit '47e96ad7ae62040ede8c9b84a192e0b718d9947a'
zandree-owneriq Dec 17, 2020
eb07296
Set withCredentials to true
zandree-owneriq Dec 17, 2020
abcc53b
Remove inmarId from Inmar bidder adapter
zandree-owneriq Dec 17, 2020
03db7f9
Remove withCredentials because it defaults to true
zandree-owneriq Dec 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions modules/inmarBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const spec = {
* @returns {boolean} True if this is a valid bid, and false otherwise
*/
isBidRequestValid: function(bid) {
return !!(bid.params && bid.params.partnerId && bid.params.adnetId);
return !!(bid.params && bid.params.partnerId);
},

/**
Expand Down Expand Up @@ -49,9 +49,6 @@ export const spec = {
return {
method: 'POST',
url: 'https://prebid.owneriq.net:8443/bidder/pb/bid',
options: {
withCredentials: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't you need this set to true to get your cookies?

},
data: payloadString,
};
},
Expand Down
2 changes: 0 additions & 2 deletions modules/inmarBidAdapter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ Please reach out to your account manager for more information.
bidder: 'inmar',
params: {
partnerId: 12345,
adnetId: 'ADb1f40rmi',
position: 1
}
}]
Expand All @@ -37,7 +36,6 @@ Please reach out to your account manager for more information.
bidder: 'inmar',
params: {
partnerId: 12345,
adnetId: 'ADb1f40rmo',
position: 0
}
}]
Expand Down
11 changes: 0 additions & 11 deletions test/spec/modules/inmarBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ describe('Inmar adapter tests', function () {
},
bidder: 'inmar',
params: {
adnetId: 'ADb1f40rmi',
partnerId: 12345
},
auctionId: '0cb3144c-d084-4686-b0d6-f5dbe917c563',
Expand All @@ -39,7 +38,6 @@ describe('Inmar adapter tests', function () {
},
bidder: 'inmar',
params: {
adnetId: 'ADb1f40rmi',
partnerId: 12345
},
auctionId: '0cb3144c-d084-4686-b0d6-f5dbe917c563',
Expand All @@ -60,7 +58,6 @@ describe('Inmar adapter tests', function () {
],
bidder: 'inmar',
params: {
adnetId: 'ADb1f40rmi',
partnerId: 12345,
},
auctionId: '851adee7-d843-48f9-a7e9-9ff00573fcbf',
Expand Down Expand Up @@ -118,7 +115,6 @@ describe('Inmar adapter tests', function () {

expect(request).to.have.property('method').and.to.equal('POST');
const requestContent = JSON.parse(request.data);
expect(requestContent.bidRequests[0].params).to.have.property('adnetId').and.to.equal('ADb1f40rmi');
expect(requestContent.bidRequests[0].params).to.have.property('partnerId').and.to.equal(12345);
expect(requestContent.bidRequests[0]).to.have.property('auctionId').and.to.equal('0cb3144c-d084-4686-b0d6-f5dbe917c563');
expect(requestContent.bidRequests[0]).to.have.property('bidId').and.to.equal('2c7c8e9c900244');
Expand Down Expand Up @@ -198,19 +194,12 @@ describe('Inmar adapter tests', function () {
})).to.equal(false);
expect(spec.isBidRequestValid({
params: {
adnetId: 'ADb1f40rmi'
}
})).to.equal(false);
expect(spec.isBidRequestValid({
params: {
partnerId: 12345
}
})).to.equal(false);
expect(spec.isBidRequestValid({
params: {
adnetId: 'ADb1f40rmi',
partnerId: 12345
}
})).to.equal(true);
});

Expand Down