add floor module support to prebid server #5721
Conversation
add video test
| @@ -569,6 +593,8 @@ const OPEN_RTB_PROTOCOL = { | |||
| utils.deepSetValue(imp, 'ext.prebid.storedauctionresponse.id', storedAuctionResponseBid.storedAuctionResponse.toString()); | |||
| } | |||
|
|
|||
| _appendFloor(firstBidRequest.bids[0], imp); | |||
There was a problem hiding this comment.
I can't figure out what should go here in the first argument
There was a problem hiding this comment.
Yeah, we'll need some logic to find the right bid to use.
Need's the context of the adUnit, so we'll want to use adUnit.code, and find a bid in firstBidRequest.bids which matches it.
Something like:
let matchedBid = find(firstBidRequest.bids, bid => bid.adUnitCode === adUnit.code);
if (matchedBid) {
_appendFloor(matchedBid, imp);
}An issue even this may have:
firstBidRequestmay be from a bidder who is not included in all adUnits, so we may miss out on setting floor for some imps.
Which means we may need / want to do a join on ALL bids not just the ones in firstBidRequest.
I would have to take a deeper look, but could come up with something.
@bszekely1 any input on using PBJS floors module to set imp.bidFloor?
I know PBS will eventually have some floor module support, but may be some time from now.
There was a problem hiding this comment.
thanks so much for taking a look! @bszekely1 and I were talking about this in the prebid server meeting recently and it seems this is quite a valid use case. @bretg recently filed #5720, which this partially solves, partly based on that discussion. Also all prebid server adapters are being asked to honor this parameter when it is available (imp[].bidfloor and imp[].bidlfoorcur) instead of reading from adapterOptions, but there is no way to currently write to it from js.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@patmmccann - what's the status of this one? It's marked as "draft" |
|
I couldn't figure it out :(
…On Wed, Oct 7, 2020, 9:27 AM bretg ***@***.***> wrote:
@patmmccann <https://github.com/patmmccann> - what's the status of this
one? It's marked as "draft"
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5721 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAM25Z5MICSLOLY3IHQFTYLSJRUFHANCNFSM4RCWNPQA>
.
|
|
Ok - I'll work towards getting this prioritized for next internal Sprint |
|
@bretg any luck putting this on the dev calendar? With the prebid 5.0 issue announced, I think it would be great to have the pbs adapter in compliance |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Closing this as I have opened #6273 |
Type of change
Description of change
this adds floor and floor curreny to prebid server requests in field imp[].bidfloor and imp[].bidfloorcur