Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new bidder adapter :mediagoBidderAdapter #5614

Merged
merged 7 commits into from
Aug 20, 2020
Merged

Add a new bidder adapter :mediagoBidderAdapter #5614

merged 7 commits into from
Aug 20, 2020

Conversation

SylviaF
Copy link
Contributor

@SylviaF SylviaF commented Aug 17, 2020

Type of change

  • [] Bugfix
  • [] Feature
  • New bidder adapter
  • [] Code style update (formatting, local variables)
  • [] Refactoring (no functional changes, no api changes)
  • [] Build related changes
  • [] CI related changes
  • [] Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • [] Other

Description of change

Add a new bidder adapter called mediagoBidderAdapter.
Our official website is https://www.mediago.io/

  • test parameters for validating bids
{
	bidder: 'mediago',
	params: {
		token: '85a6b01e41ac36d49744fad726e3655d' // required, send email to [email protected] to get the corresponding token
	}
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer([email protected]
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@lgtm-com
Copy link

lgtm-com bot commented Aug 17, 2020

This pull request introduces 50 alerts when merging 5aecdb8 into db02d8a - view on LGTM.com

new alerts:

  • 50 for Useless regular-expression character escape

@lgtm-com
Copy link

lgtm-com bot commented Aug 17, 2020

This pull request introduces 50 alerts when merging dc364b1 into db02d8a - view on LGTM.com

new alerts:

  • 50 for Useless regular-expression character escape

modules/mediagoBidAdapter.js Outdated Show resolved Hide resolved
modules/mediagoBidAdapter.js Outdated Show resolved Hide resolved
modules/mediagoBidAdapter.js Outdated Show resolved Hide resolved
test/spec/modules/mediagoBidAdapter_spec.js Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Aug 18, 2020

This pull request introduces 50 alerts when merging 5c9fb22 into 97713dd - view on LGTM.com

new alerts:

  • 50 for Useless regular-expression character escape

@bretg
Copy link
Collaborator

bretg commented Aug 19, 2020

Docs PR prebid/prebid.github.io#2234

@GLStephen
Copy link
Collaborator

LGTM - thanks for providing a 100% fill bidder example

@GLStephen GLStephen merged commit a1692da into prebid:master Aug 20, 2020
BrightMountainMediaInc pushed a commit to BrightMountainMediaInc/Prebid.js that referenced this pull request Sep 14, 2020
* mediago bid adaptor

* 修改去掉固定ip

* mediago bid adapter: add test spec

* spec code style

* change into prod EP and auto size.

* delete other param

* 修改为强制https协议
BrightMountainMediaInc pushed a commit to BrightMountainMediaInc/Prebid.js that referenced this pull request Sep 14, 2020
@patmmccann
Copy link
Collaborator

patmmccann commented May 25, 2021

Hi @SylviaF

You may have noticed all the regular expression issues flagged in the lgtm alert
#5614 (comment)

Would you consider fixing?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants