Adds support for additional consent #5600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smenzer
requested changes
Aug 13, 2020
smenzer
reviewed
Aug 13, 2020
smenzer
approved these changes
Aug 13, 2020
|
docs PR prebid/prebid.github.io#2219 |
|
One example of a cmp supporting this already is https://support.cookiebot.com/hc/en-us/articles/360007652694-Cookiebot-and-the-IAB-Consent-Framework |
|
From Prebid.js slack, for reviewer: https://prebid.slack.com/archives/C7TLBVAH3/p1597348755293600?thread_ts=1597345850.288600&cid=C7TLBVAH3 |
robertrmartinez
approved these changes
Aug 17, 2020
|
I think I was probably just matching line 639
…On Mon, Aug 17, 2020, 1:31 PM Robert Ray Martinez III < ***@***.***> wrote:
***@***.**** approved this pull request.
Looks good, minor nitpick,
why use utils.isString in one module, but regular typeof check in the
other?
Not a big deal of course haha!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5600 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAM25Z6PN5WOYSUDJUW7OZLSBFSQ7ANCNFSM4P5DFJPQ>
.
|
jsnellbaker
reviewed
Aug 17, 2020
| @@ -641,6 +641,9 @@ const OPEN_RTB_PROTOCOL = { | |||
| } | |||
| utils.deepSetValue(request, 'regs.ext.gdpr', gdprApplies); | |||
| utils.deepSetValue(request, 'user.ext.consent', firstBidRequest.gdprConsent.consentString); | |||
| if (firstBidRequest.gdprConsent.addtlConsent && typeof firstBidRequest.gdprConsent.addtlConsent === 'string') { | |||
| utils.deepSetValue(request, 'user.ext.ConsentedProvidersSettings.consented_providers', firstBidRequest.gdprConsent.addtlConsent); | |||
There was a problem hiding this comment.
Just to confirm - are we sure that this field is supported by PBS?
There was a problem hiding this comment.
that was the field @bretg proposed on #5389 (comment) bullet point 2
jsnellbaker
approved these changes
Aug 17, 2020
BrightMountainMediaInc
pushed a commit
to BrightMountainMediaInc/Prebid.js
that referenced
this pull request
Sep 14, 2020
* add addtlConsent consent to consent object * add unit test for additional consent * Update consentManagement.js * Update index.js * Update prebidServerBidAdapter_spec.js * condense else if
BrightMountainMediaInc
pushed a commit
to BrightMountainMediaInc/Prebid.js
that referenced
this pull request
Sep 14, 2020
This reverts commit e2dcb8b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Solves for #5389 on js following the extension to the TCData object proposed by Google here https://support.google.com/admanager/answer/9681920?hl=en