oneVideo Adapter: User sync pixel updates (VIDEOPUB-17981) #5583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
failed unit tests with GDPR |
adam-browning
changed the title
harpere
requested changes
Aug 10, 2020
|
Hi @harpere and thanks for reviewing! |
kprasadpvv
reviewed
Aug 11, 2020
| expect(pixel[2].type).to.equal('image'); | ||
| expect(pixel[2].url).to.equal('https://sync-tm.everesttech.net/upi/pid/m7y5t93k?gdpr=1&gdpr_consent=' + GDPR_CONSENT_STRING + '&redir=https%3A%2F%2Fpixel.advertising.com%2Fups%2F55986%2Fsync%3Fuid%3D%24%7BUSER_ID%7D%26_origin%3D0&gdpr=1&gdpr_consent=' + encodeURI(GDPR_CONSENT_STRING)); | ||
| expect(pixel[1].type).to.equal('image'); | ||
| expect(pixel[1].url).to.equal('https://sync-tm.everesttech.net/upi/pid/m7y5t93k?gdpr=1&gdpr_consent=' + GDPR_CONSENT_STRING + '&redir=https%3A%2F%2Fpixel.advertising.com%2Fups%2F55986%2Fsync%3Fuid%3D%24%7BUSER_ID%7D%26_origin%3D0&gdpr=1&gdpr_consent=' + encodeURI(GDPR_CONSENT_STRING)); |
There was a problem hiding this comment.
@adam-browning, Not Important , just a suggestion:
It would be good if we check for pixel[0].url / pixel[2].url to as you are actually changing those pixels.
like below:
expect(pixel[0].url).to.equal('https://pixel.advertising.com/ups/57304/sync?gdpr=&gdpr_consent=&_origin=0&redir=true')
There was a problem hiding this comment.
Understood and thank you for the review @prasad457!
Updated tests accordingly.
kprasadpvv
approved these changes
Aug 11, 2020
kprasadpvv
approved these changes
Aug 12, 2020
|
Hi @harpere |
harpere
approved these changes
Aug 18, 2020
BrightMountainMediaInc
pushed a commit
to BrightMountainMediaInc/Prebid.js
that referenced
this pull request
Sep 14, 2020
* updated DBM sync pixel to ups/57304 + removed yahoo sync pixel * updated unit tests * updated GDPR tests * Update package-lock.json * Update package-lock.json * update local branch to origin * added sync pixel unit tests * Update package-lock.json
BrightMountainMediaInc
pushed a commit
to BrightMountainMediaInc/Prebid.js
that referenced
this pull request
Sep 14, 2020
…rebid#5583)" This reverts commit 84170a1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Update to oneVideoBidAdapter cookie sync pixel urls.
Updated DBM sync pixel to ups/57304 + removed old yahoo sync pixel.
adapter version jump to 3.0.4
Other information
@DeepthiNeeladri please review thank you!