-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PubMatic: Support for Outstream Renderer (BlueBilyWig Renderer) #5553
Conversation
Latest Pull
Latest Code
changes to support native in pubmaticbid adapter
…utstream_renderer
…utstream_renderer
Outstream renderer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I was trying to test this new renderer with the modified params from the md file, the bid seemed to be rejected by the adapter code. I saw the following warning message in my console logs:
ARNING: PubMatic: Skipping the non-standard adslot: pubmatic_test2 {"bidder":"pubmatic","params":{"publisherId":"156209","oustreamAU":"renderer_test_pubmatic","adSlot":"pubmatic_test2","pmzoneid":"zone1, zone11","lat":"40.712775","lon":"-74.005973","yob":"1982","kadpageurl":"www.test.com","gender":"M","kadfloor":"0.50","currency":"AUD","dctr":"key1=123|key2=345","bcat":["IAB1-5","IAB1-7"],"deals":["deal-id-1","deal-id-200"],"adUnit":"pubmatic_test2","adUnitIndex":"0","width":0,"height":0},"crumbs":{"pubcid":"70d4a196-602d-4d47-8a99-8b0cd9522aeb"},"fpd":{"context":{"adServer":{"name":"gam","adSlot":"/19968336/prebid_outstream_adunit_1"},"pbAdSlot":"/19968336/prebid_outstream_adunit_1"}},"mediaTypes":{"video":{"playerSize":[[640,480]],"context":"outstream","mimes":["video/mp4"]}},"adUnitCode":"video1","transactionId":"10437501-5e47-4c8f-a138-0cec6a7f49df","sizes":[[640,480]],"bidId":"2f2beae8dcc78b","bidderRequestId":"1bfbb6329a9f77","auctionId":"05e6f0c7-68e9-4f6d-88ef-fd3ae4dd71fd","src":"client","bidRequestsCount":1,"bidderRequestsCount":1,"bidderWinsCount":0}
Can you please take a look to see which params are causing the issue? If there are entirely different values that should be used for this testing (such as the adslot
, publisherId
, etc) - could you provide a copy of the adunit setup?
Thanks.
Hi @jsnellbaker, video params are mandatory for video request in pubmatic adapter that's why it is failing.
|
@jsnellbaker can you please look at the same ? and please let me know if more information is required. |
Sorry for the delay, I was ooo for a bit. Thank you for providing the test adUnit. I tried to use it, but I wasn't seeing a response from the adserver. Below is a copy of the request:
The response returned as a 204 code with no data. Can you take a look at the above? If there's anything you'd like me to try, please let me know. |
@jsnellbaker, thanks for checking with updated adUnits. Please add query param pubmaticTest=true to get the test bid from pubmatic. I've setup a sample code for the same with updated code - >https://codesandbox.io/s/sweet-pare-nykh5?file=/index.html PS : Please refresh the test page, cause the first time codesandbox transpiles the files. You will the pubmatic ad in player. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for providing the info and the test pages. LGTM
…id#5553) * changes to support native in pubmaticbid adapter * Removed port from endpoint * Removed protocol from endpoint * Formatting * Fix request payload * Updated test case * Changed request and response as per ortb spec * Change in request and response * Removed comments and extra code * Code Review comments * Code Review Comments and Test cases for request and response * Removed data type as all data asset types are handled * Code Review Changes * Code Review Comments * Supporting both banner and native and sending 0x0 in case of native * Bug Fixes * Bug response not processed by prebid * Change warning message * Fixed typo * Do not send request in case of invalid native bid * Do not send request in case of invalid native requests * objects converted to strings in log for debug purposes * Fixed logic to check for required parmas * Fixed typo for stringify * documentation for native * Review comments from Prebid * Typo * Typo * Updated pub id for native * Code Review * Support for pubid * Test Cases for PubCommonId in PubMatic adapter * Delete yarn.lock * Rename adaptermanager.js to adapterManager.js * Rename yieldNexusBidAdapter.js to yieldnexusBidAdapter.js * Rename yieldNexusBidAdapter.md to yieldnexusBidAdapter.md * Rename yieldNexusBidAdapter_spec.js to yieldnexusBidAdapter_spec.yieldnexusBidAdaptera * Rename yieldnexusBidAdapter_spec.yieldnexusBidAdaptera to yieldnexusBidAdapter_spec.js * bluebillywig outstream player support in pubmatic adapter * removed pubcommon id test cases * BBW Renderer
…r) (prebid#5553)" This reverts commit 4d1eda6.
@@ -25,6 +25,7 @@ var adUnits = [ | |||
bidder: 'pubmatic', | |||
params: { | |||
publisherId: '156209', // required | |||
oustreamAU: 'renderer_test_pubmatic', // required if mediaTypes-> video-> context is 'outstream'. This value can be get by BlueBillyWig Team. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a typo. It should say outstreamAU
Type of change
Description of change
PubMatic adapter now supports bluebillywig renderer for outstream videos.
Other information
PR for Updating Bidder Doc for new parameter -> prebid/prebid.github.io#2170