AdButler Bid Adapter: Add ability to include extra query params #5543
Conversation
|
hey @dharton , I don't see that you attached the PR for https://github.com/prebid/prebid.github.io/, where you would describe this additional parameter. Also, can you include it in the example in this repo: |
dharton
force-pushed
the
adbutler-extra-params
branch
from
4240baa to
84142f6
Compare
|
Hi @aleksatr Thank you for your feedback! I've updated the .md file in this repo and please see the link below for the corresponding documentation pull request. Please let me know if there's anything else you see! |
| @@ -25,13 +25,15 @@ export const spec = { | |||
| let requestURI; | |||
| let serverRequests = []; | |||
| let zoneCounters = {}; | |||
| let extraParams = {}; | |||
|
|
|||
| for (i = 0; i < validBidRequests.length; i++) { | |||
| bidRequest = validBidRequests[i]; | |||
| zoneID = utils.getBidIdParameter('zoneID', bidRequest.params); | |||
| accountID = utils.getBidIdParameter('accountID', bidRequest.params); | |||
| keyword = utils.getBidIdParameter('keyword', bidRequest.params); | |||
There was a problem hiding this comment.
You should be reading kw from fpd.context when available.
There was a problem hiding this comment.
Hi @patmmccann
Thanks for the advice, that seems really handy!
Perhaps that should be a separate commit & pull request since it's unrelated to this change? I'd be dropping that in as a replacement to the 'keyword' bid param on line 34 there.
There was a problem hiding this comment.
makes sense ty! I brought it up bc kw was an example of your extra param.
|
LGTM |
Type of change
Description of change
This change will allow users of the AdButler Bid Adapter to pass other potentially necessary parameters in their ad requests.