JW Player Real Time Data Provider #5537
Conversation
|
This pull request introduces 1 alert when merging 6c96794 into eb467f4 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 34b9f9b into c933c4f - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 00f32e3 into c933c4f - view on LGTM.com new alerts:
|
| fetchTargetingInformation(params); | ||
| }); | ||
|
|
||
| submodule('realTimeData', jwplayerSubmodule); |
There was a problem hiding this comment.
@patmmccann this is the line where we register as an RTD submodule
There was a problem hiding this comment.
ty! how do you like this format?
There was a problem hiding this comment.
Do you mean how do I like having the jwplayer module be a submodule of an existing module ? I think it's great for reusability and consistency across all rtd providers. Thank you for suggesting this approach.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
karimMourra
force-pushed
the
task/AD-775-rearch
branch
from
00f32e3 to
e444781
Compare
|
This pull request introduces 1 alert when merging e444781 into db02d8a - view on LGTM.com new alerts:
|
karimMourra
force-pushed
the
task/AD-775-rearch
branch
from
e444781 to
5bcb160
Compare
|
@idettman the PR that was blocking this PR has been merged. Could you please review ? |
|
@robertrmartinez Could you please review this PR ? It was blocked by #5519 |
* [AD-469] Add player vendor. * ssets up targeting module * implements getTargeting * implements getPlayer * blocks bids until all targeting requests complete * makes getTarget more resilient * enables mdule hook * replaces triple dot notation * Revert "replaces triple dot notation" This reverts commit 7a76ea6. * Revert "Revert "replaces triple dot notation"" This reverts commit 130aa2a. * checks current item only if mediaid is missing * adds unit tests * completes test cases * stores segments for current item * renames jwp targeting * refactors fetch tests * refactors get targeting tests * refactors blocking tests * renames module * cleans changes made to app nexus * removes setup and player utilities * renames onFetchCompletion * renames onFetchCOmpletion in unti tests * throws instead of early return * reduces timeout and introduces override * targeting timeout supersedes * renames feed fetch timeout * adds inline doc * uses find util * adds jwplayer rtd provider * implements targeting retrieval * ensures provider is found * implements init * jwTargeting is object * commits test file * adds file extension * adds tests * fixes test for proper structure * uses default clock mock * ends reqs before rtd module timeout * removes obsolete export * request counts updates in aggregate * cleans server mock after each test * deletes jwplayer targeting * includes content id * adds test for missing segment * getSegments is nullable * replaces condition with guard * updates doc * adds md file * adds example page Co-authored-by: vseventer <[email protected]> Co-authored-by: karimJWP <[email protected]>
This reverts commit ab4b75b.
Type of change
Description of change
Adds the jwplayer RTD Provider module which allows Ad Bidders to obtain JW Player's Video Ad Targeting information.
It is a submodule of the RTD Module.
The module will fetch segments for the media ids present in the prebid config when the module loads. When bid requests are made, it will check for params in the AdUnit set by the publisher and will set the corresponding targeting information to the real time data returned in
getData.[email protected]
Other information
The base branch of this PR is #5519 and should be merged after it. The only changes made to it are the addition of
jwplayerRtdProvider.jsandjwplayerRtdProvider_spec.js, and the modification of.submodules.json