mantis privacy support, removed unsupported media types #5494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parisholley
added a commit
to parisholley/prebid.github.io
that referenced
this pull request
Jul 15, 2020
requires prebid/Prebid.js#5494 to be merged
MartianTribe
pushed a commit
to prebid/prebid.github.io
that referenced
this pull request
Jul 15, 2020
requires prebid/Prebid.js#5494 to be merged
aleksatr
reviewed
Jul 16, 2020
|
hey @parisholley , for any adapter (new or updated) submission, code under review must have at least 80% unit test coverage. From what I see mantisBidAdapter has 54% coverage. Please increase unit test coverage above the 80% threshold. To generate and view unit test coverage: |
|
@aleksatr done :) |
|
This pull request fixes 1 alert when merging 40270e1 into 1049d07 - view on LGTM.com fixed alerts:
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.