ATS-analytics - fix check for safari browser #5474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 9d3b306 into a2ec9c2 - view on LGTM.com new alerts:
|
bretg
reviewed
Jul 14, 2020
| @@ -2,7 +2,7 @@ import atsAnalyticsAdapter from '../../../modules/atsAnalyticsAdapter.js'; | |||
| import { expect } from 'chai'; | |||
| import adapterManager from 'src/adapterManager.js'; | |||
| import {server} from '../../mocks/xhr.js'; | |||
| import {browserIsChrome, browserIsEdge, browserIsFirefox, browserIsSafari} from '../../../modules/atsAnalyticsAdapter.js'; | |||
| import {checkUserBrowser, browserIsChrome, browserIsEdge, browserIsSafari} from '../../../modules/atsAnalyticsAdapter.js'; | |||
There was a problem hiding this comment.
Is there a reason for not testing browserIsFirefox()?
There was a problem hiding this comment.
Hi, yes, I didn't manage to mock InstallTrigger. We use this check to determine if user browser is firefox
(typeof InstallTrigger !== 'undefined').
https://developer.mozilla.org/en-US/docs/Web/API/InstallTrigger
https://stackoverflow.com/questions/9847580/how-to-detect-safari-chrome-ie-firefox-and-opera-browser/9851769
|
Hi @bretg, |
bretg
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Safari is reporting a value of “false” for userBrowser in ATS Analytics.
Other information
@bretg