Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lotame id system #5388
Add lotame id system #5388
Changes from 14 commits
08ce0ee
4ee8ccd
c27c19a
9d41c90
ec826ec
fc32767
864339e
f5532ba
8231cc6
627633b
beba511
be46374
b994d26
1c5e954
74bf928
628cb21
93ee9b8
33b0268
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again, i may be missing something, but here you are storing to the prebid cache object the entire
responseObj
, which seems to contain several keys, including thecore_id
andprofile_id
. however, in your decode function on line 157, you are checking if thevalue
is a string, otherwise you returnundefined
. my understanding is that thevalue
you receive indecode()
will be the same thing you pass in thecallback()
here...which means decode would always return undefined. again, i'm sure i'm missing something here since you're doing some of your own cache management, but wanted to flag this as it doesn't seem correct.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking into this part as it was tricky to trace what
decode
will always get as there are a couple of different pathsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed up a fix, thanks for catching this!