Reset GPT targeting for custom div ids #5132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harpere
approved these changes
Apr 17, 2020
harpere
added
the
needs 2nd review
jaiminpanchal27
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
When resetting targeting provide
customSlotMatchingfunction (that is also used for setting gpt targeting).Right now, code is checking whether it should reset targeting: if adUnit code is the same as gpt slot adUnit path or if adUnit code is the same as div id. If all these checks fail, use
customSlotMatchingfunction as fallback to determine if targeting should be reset.Other information
This PR is addressing #5131 issue.