pbsBidAdapter: register response currency #4638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idettman
added
bug
needs 2nd review
mkendall07
added
LGTM
and removed
needs 2nd review
jsnellbaker
approved these changes
Dec 18, 2019
sa1omon
pushed a commit
to CleanMediaNet/Prebid.js
that referenced
this pull request
Dec 19, 2019
tadam75
pushed a commit
to smartadserver/Prebid.js
that referenced
this pull request
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bug fix for #4579
Description of change
Prebid Server Bid Adapter was not copying Prebid Server's $.cur field into the local bid response object, causing the bid's currency to be doubly converted. Ouch.