Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fidelity Media Bid Adapter. Prebid.js v3 support, CCPA support. #4630

Merged
merged 10 commits into from
Dec 18, 2019
Merged

Fidelity Media Bid Adapter. Prebid.js v3 support, CCPA support. #4630

merged 10 commits into from
Dec 18, 2019

Conversation

onaydenov
Copy link
Contributor

@onaydenov onaydenov commented Dec 18, 2019

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Fidelity Media Bid Adapter Update.
Add Prebid.js v.3 support.
Add CCPA support.

  • test parameters for validating bids
    var adUnits = [{
      code: 'banner-ad-div',
      mediaTypes: {
        banner: {
          sizes: [[300, 250]],
        }
      },
      bids: [{
        bidder: 'fidelity',
        params: {
          zoneid: '27248',
          floor: 0.005,
          server: 'x.fidelity-media.com'
        }
      }]
    }];

  • contact email of the adapter’s maintainer [email protected]
  • official adapter submission

Other information

PR for the docs: prebid/prebid.github.io#1707

@onaydenov
Copy link
Contributor Author

@mkendall07 the build goes well locally but here we see errors. Could you please look into.

@jsnellbaker jsnellbaker self-requested a review December 18, 2019 18:28
@jsnellbaker jsnellbaker self-assigned this Dec 18, 2019
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @onaydenov

These changes LGTM.

I would also recommend though to submit the CCPA changes to the 2.44.x-legacy branch, so your adapter there can be compliant for anyone still running 2.x versions of Prebid.js. You will have to open a separate PR to make that update.

@jsnellbaker jsnellbaker merged commit ad6719a into prebid:master Dec 18, 2019
sa1omon pushed a commit to CleanMediaNet/Prebid.js that referenced this pull request Dec 19, 2019
…id#4630)

* Fidelity Media bid adapter update.

Add Prebid.js v.3 support.
Add CCPA support.

* Fidelity Media bid adapter update.

Add Prebid.js v.3 support.
Add CCPA support.

* PR Error fix

* error fix

* PR Error fix

* PR Error fix

* PR Error fix

* pr error fix

* Auction timeout removed

* Fix. Timeout is back
tadam75 pushed a commit to smartadserver/Prebid.js that referenced this pull request Jan 9, 2020
…id#4630)

* Fidelity Media bid adapter update.

Add Prebid.js v.3 support.
Add CCPA support.

* Fidelity Media bid adapter update.

Add Prebid.js v.3 support.
Add CCPA support.

* PR Error fix

* error fix

* PR Error fix

* PR Error fix

* PR Error fix

* pr error fix

* Auction timeout removed

* Fix. Timeout is back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants