Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-submit bid adapter for AdUp Technology #4603

Merged
merged 1 commit into from
Dec 18, 2019

Conversation

SteffenAnders
Copy link
Contributor

@SteffenAnders SteffenAnders commented Dec 16, 2019

Type of change

  • Official adapter submission
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)

Description of change

The adapter already existed and worked but was removed because of compatibility problems with latest Prebid.js 3.0 release. With this pull request i want to re-submit our adapter with the required changes:

  • Force HTTPS
  • Add Support for mediaTypes.banner.sizes
  • Remove usage of deprecated utils.getTopWindowUrl()
  • Remove usage of deprecated utils.getTopWindowReferrer()

Test parameters

{
  code: 'banner',
  mediaTypes: {
    banner: {
      sizes: [[300, 250], [300, 600]],
    }
  },
  bids: [{
    bidder: 'aduptech',
    params: {
      publisher: 'prebid',
      placement: '12345'
    }
  }]
}

Maintainers

Other information

New PR for the docs: prebid/prebid.github.io#1692
Initial PR for the adapter: #2809
Initial PR for the docs: prebid/prebid.github.io#866

@SteffenAnders
Copy link
Contributor Author

SteffenAnders commented Dec 16, 2019

The failed tests in CircleCI have nothing to do with our adapter. :(

@SteffenAnders SteffenAnders force-pushed the re-submit-aduptech-bid-adapter branch 2 times, most recently from e5db9bb to acd26b8 Compare December 17, 2019 08:14
@SteffenAnders
Copy link
Contributor Author

rebased to master

Copy link
Contributor

@msm0504 msm0504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SteffenAnders Changes LGTM and have removed the use of deprecated functions.

I have 1 suggestion, though. Noticed multiple lines (106, 159, 177) checking levels within an object before getting a value. The utils.deepAccess function could be used instead. The docs for it can be seen here.

@SteffenAnders SteffenAnders force-pushed the re-submit-aduptech-bid-adapter branch from acd26b8 to 859c1a6 Compare December 18, 2019 18:18
@SteffenAnders
Copy link
Contributor Author

Update:

  • using utils.deepAccess
  • rebased to master

@msm0504 msm0504 added the LGTM label Dec 18, 2019
@msm0504 msm0504 merged commit 0d621e9 into prebid:master Dec 18, 2019
sa1omon pushed a commit to CleanMediaNet/Prebid.js that referenced this pull request Dec 19, 2019
tadam75 pushed a commit to smartadserver/Prebid.js that referenced this pull request Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants