Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdKernel: Fix alias unit test #4373

Closed
wants to merge 1 commit into from

Conversation

romanantropov
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@bretg bretg changed the title Add alias AdKernel: Fix alias unit test Oct 24, 2019
@bretg
Copy link
Collaborator

bretg commented Oct 24, 2019

Sorry @romanantropov , but this PR really needs to be merged with #4290 -- neither of them can pass unit tests without each other. Please close this PR and add your unit test update to 4290

@bretg
Copy link
Collaborator

bretg commented Oct 24, 2019

Never mind. I did it for you.

@bretg bretg closed this Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants