create stubs for localStorage in widespaceBidAdapter test file #4208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This PR is meant to help prevent sporadic browserstack unit test failures related to use of
localStoragein thewidespaceBidAdapterfile.The error causing the test failures is:
Access is denied. Based on some research, this error is due to when some permission settings in IE browsers prevents access tolocalStorage.The sporadic nature of the error is likely just timing/initialization of the Browserstack IE 11 browser not having the right setting(s) at the time of the test. Normally rerunning the job causes the tests to pass fine, but the frequency of this error over time has made rerunning the jobs become tedious to do - especially when the related PR isn't about the
widespaceBidAdapter.See example here in recent circleCI test job for a failure and subsequent pass:
https://circleci.com/gh/prebid/Prebid.js/3857 (fail)
https://circleci.com/gh/prebid/Prebid.js/3858 (pass)