Fix for #4047 #4063
Fix for #4047 #4063
Conversation
…xcept instream video and banner.
|
Build failure appears to be due to an error when running RealVu Analytics Adapter tests. |
There was a problem hiding this comment.
@dpapworth-qc
I took a look through the changes, and they seem to be good.
There was one thing I noted as a potential thought, but not strictly needed. Let me know what you think about it.
Thanks!
| } else if (bid.mediaTypes.banner) { | ||
| imp = makeBannerImp(bid); | ||
| } else { | ||
| // Unsupported mediaType |
There was a problem hiding this comment.
Do you want to throw a warning/info message message here to note that an unsupported bid type was ignored by the adapter (if only for future diagnostic information)?
|
@dpapworth-qc As an update, I reran the circleci tests. They should be good. The current failure (where the job seemed to stall) was fixed in a recent update to master. If you resync your branch and get the update; it should resolve the issue. |
|
@jsnellbaker i've added a log message for unsupported media types, and i've merged the current master branch. |
* Changed isBidRequestValid to reject bid requests missing required parameters. * Filter outstream video bid requests. * Improved detection of different media types. Ignore all media types except instream video and banner. * Added test to confirm behaviour with multi-format request. * Removed unnecessary change to bid sizes. * Removed unused imports and tests. * Added log message for unsupported media types.
Type of change
Description of change
Resolves #4047.
Change isBidRequestValid to reject bid requests missing required parameters, rather than unsupported media types.
Filter unsupported media types when building requests.
Add test for multi-format ad units to verify expected behaviour.
Other information