add check to see if adObject is present #4058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnellbaker
added
needs 2nd review
jaiminpanchal27
approved these changes
Aug 6, 2019
robertrmartinez
approved these changes
Aug 6, 2019
sa1omon
pushed a commit
to gamoshi/Prebid.js
that referenced
this pull request
Nov 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Aims to fix #2953.
If two instances of Prebid.js are loaded in the same scope, window.parent.postMessage is broadcasting an event, to which both the instances are listening. Hence, one of the instances is not able to find and adObject matching the adId in the secureCreative.js, receiveMessage method, which result in an error.
This PR adds a check to make sure adObject is defined before calling other functions depending on the adObject to function properly.