Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for referrer in TrustX Bid Adapter #4039

Merged
merged 40 commits into from
Jul 30, 2019
Merged

Hotfix for referrer in TrustX Bid Adapter #4039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
031fa56
Add trustx adapter and tests for it
PWyrembak Aug 15, 2017
319cadd
update integration example
PWyrembak Aug 15, 2017
0e877f9
Merge remote-tracking branch 'upstream/master'
PWyrembak Aug 16, 2017
0425234
Merge remote-tracking branch 'upstream/master'
PWyrembak Sep 8, 2017
69ab1f4
Update trustx adapter
PWyrembak Sep 9, 2017
817f2fa
Merge remote-tracking branch 'upstream/master'
PWyrembak Sep 19, 2017
ef50012
Post-review fixes of Trustx adapter
PWyrembak Sep 19, 2017
bd5b75c
Merge remote-tracking branch 'upstream/master'
PWyrembak Oct 3, 2017
bff944b
Merge remote-tracking branch 'upstream/master'
PWyrembak Oct 10, 2017
843440d
Code improvement for trustx adapter: changed default price type from …
PWyrembak Oct 10, 2017
cd01e9b
Merge remote-tracking branch 'upstream/master'
PWyrembak Oct 17, 2017
aa249b5
Update TrustX adapter to support the 1.0 version
PWyrembak Oct 17, 2017
119728b
Merge remote-tracking branch 'upstream/master'
PWyrembak Oct 20, 2017
5f60ac3
Make requested changes for TrustX adapter
PWyrembak Oct 20, 2017
2628673
Updated markdown file for TrustX adapter
PWyrembak Oct 24, 2017
b3badf9
Merge remote-tracking branch 'upstream/master'
PWyrembak Oct 26, 2017
292b4dd
Fix TrustX adapter and spec file
PWyrembak Oct 26, 2017
b3e1465
Merge remote-tracking branch 'upstream/master'
PWyrembak Dec 19, 2017
09b581a
Update TrustX adapter: r parameter was added to ad request as cache b…
PWyrembak Dec 19, 2017
7b16a1c
Merge remote-tracking branch 'upstream/master'
PWyrembak May 17, 2018
73b7249
Add support of gdpr to Trustx Bid Adapter
PWyrembak May 17, 2018
08ca36e
Merge remote-tracking branch 'upstream/master'
PWyrembak Aug 6, 2018
4974e55
Add wtimeout to ad request params for TrustX Bid Adapter
PWyrembak Aug 6, 2018
240306f
Merge remote-tracking branch 'upstream/master'
PWyrembak Aug 10, 2018
9175298
TrustX Bid Adapter: remove last ampersand in the ad request
PWyrembak Aug 10, 2018
d98be98
Merge remote-tracking branch 'upstream/master'
PWyrembak Feb 12, 2019
83b3aaf
Update TrustX Bid Adapter to support identical uids in parameters
PWyrembak Feb 15, 2019
3e348d2
Merge remote-tracking branch 'upstream/master'
PWyrembak Feb 15, 2019
fc2e05a
Merge remote-tracking branch 'upstream/master'
PWyrembak Feb 20, 2019
f77c2ee
Update TrustX Bid Adapter to ignore bids that sizes do not match the …
PWyrembak Feb 20, 2019
cba862b
Merge remote-tracking branch 'upstream/master'
PWyrembak Feb 28, 2019
f3de951
Merge remote-tracking branch 'upstream/master'
PWyrembak Mar 13, 2019
549ea7a
Update TrustX Bid Adapter to support instream and outstream video
PWyrembak Mar 13, 2019
4bca1d6
Merge remote-tracking branch 'upstream/master'
PWyrembak Apr 15, 2019
0bce985
Added wrapperType and wrapperVersion parameters in ad request for Tru…
PWyrembak Apr 15, 2019
59719fc
Merge remote-tracking branch 'upstream/master'
PWyrembak Jul 4, 2019
c604ba0
Update TrustX Bid Adapter to use refererInfo instead depricated funct…
PWyrembak Jul 5, 2019
ed34d02
Merge remote-tracking branch 'upstream/master'
PWyrembak Jul 30, 2019
aedbb7c
HOTFIX for referrer encodind in TrustX Bid Adapter
PWyrembak Jul 30, 2019
9a6110d
Fix test for TrustX Bid Adapter
PWyrembak Jul 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/trustxBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export const spec = {

if (bidderRequest) {
if (bidderRequest.refererInfo && bidderRequest.refererInfo.referer) {
payload.u = encodeURIComponent(bidderRequest.refererInfo.referer);
payload.u = bidderRequest.refererInfo.referer;
}
if (bidderRequest.timeout) {
payload.wtimeout = bidderRequest.timeout;
Expand Down
10 changes: 5 additions & 5 deletions test/spec/modules/trustxBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ describe('TrustXAdapter', function () {
referer: 'http://example.com'
}
};
const encodedReferer = encodeURIComponent(bidderRequest.refererInfo.referer);
const referrer = bidderRequest.refererInfo.referer;

let bidRequests = [
{
Expand Down Expand Up @@ -95,7 +95,7 @@ describe('TrustXAdapter', function () {
const request = spec.buildRequests([bidRequests[0]], bidderRequest);
expect(request.data).to.be.an('string');
const payload = parseRequest(request.data);
expect(payload).to.have.property('u', encodedReferer);
expect(payload).to.have.property('u', referrer);
expect(payload).to.have.property('pt', 'net');
expect(payload).to.have.property('auids', '43');
expect(payload).to.have.property('sizes', '300x250,300x600');
Expand All @@ -108,7 +108,7 @@ describe('TrustXAdapter', function () {
const request = spec.buildRequests(bidRequests, bidderRequest);
expect(request.data).to.be.an('string');
const payload = parseRequest(request.data);
expect(payload).to.have.property('u', encodedReferer);
expect(payload).to.have.property('u', referrer);
expect(payload).to.have.property('pt', 'net');
expect(payload).to.have.property('auids', '43,43,45');
expect(payload).to.have.property('sizes', '300x250,300x600,728x90');
Expand All @@ -120,7 +120,7 @@ describe('TrustXAdapter', function () {
const request = spec.buildRequests(bidRequests, bidderRequest);
expect(request.data).to.be.an('string');
const payload = parseRequest(request.data);
expect(payload).to.have.property('u', encodedReferer);
expect(payload).to.have.property('u', referrer);
expect(payload).to.have.property('pt', 'gross');
expect(payload).to.have.property('auids', '43,43,45');
expect(payload).to.have.property('sizes', '300x250,300x600,728x90');
Expand All @@ -133,7 +133,7 @@ describe('TrustXAdapter', function () {
const request = spec.buildRequests(bidRequests, bidderRequest);
expect(request.data).to.be.an('string');
const payload = parseRequest(request.data);
expect(payload).to.have.property('u', encodedReferer);
expect(payload).to.have.property('u', referrer);
expect(payload).to.have.property('pt', 'net');
expect(payload).to.have.property('auids', '43,43,45');
expect(payload).to.have.property('sizes', '300x250,300x600,728x90');
Expand Down