update fun-hooks with fix checking if global Proxy is native #4030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snapwich
force-pushed
the
update-fun-hooks
branch
from
e1515a1 to
2d24be6
Compare
9 tasks
snapwich
force-pushed
the
update-fun-hooks
branch
from
2d24be6 to
27bdb21
Compare
bretg
approved these changes
Jul 28, 2019
jaiminpanchal27
approved these changes
Jul 30, 2019
|
is this the fix for this, which i noticed started appearing in the last few versions: fun-hooks: referenced 'registerAdserver' but it was never created |
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
|
No it is not |
leonardlabat
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
Aug 6, 2019
sa1omon
pushed a commit
to gamoshi/Prebid.js
that referenced
this pull request
Nov 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Update
fun-hooksto latest which includes a check forProxy.revocableto determine if globalProxyobject is native implementation or just some global that a third-party decided to create.Other information
fixes #4024
related fix in fun-hooks: snapwich/fun-hooks@a9121c7 and snapwich/fun-hooks@db11565