Improve Piximedia Adapter #4026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 10a10d6.
sumit116
approved these changes
Jul 31, 2019
There was a problem hiding this comment.
Tested the adapter on hello_world page. pbsizes is getting added to the payload for request to the adapter'r endpoint, hence approving the PR.
Hi @christopher-allene-piximedia, can you update the specs to test if the newly added param is getting added (piximediaBidAdapter_spec.js:47) to bid request data?
sumit116
suggested changes
Aug 6, 2019
|
Hi @sumit116, thanks for your review. I updated the tests. |
|
Looks like CI failed because of some error in Is there anything I should do? |
|
@christopher-allene-piximedia I reran the build and it passed this time. |
jsnellbaker
approved these changes
Aug 6, 2019
sa1omon
pushed a commit
to gamoshi/Prebid.js
that referenced
this pull request
Nov 28, 2019
* Add Piximedia adapter * Add piximediaBidAdapter.md * Improve protocol of Piximedia bidder * Add Piximedia adapter * Fix piximediaBidAdapter_spec.js style * Fix Piximedia adapter * Revert "Fix Piximedia adapter" This reverts commit 10a10d6. * Impprove Piximedia adapter * Remove CR at end of file * Add test for pbsizes in Piximedia adapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This PR fixes handling bids of different sizes.
Thanks in advance!