Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple sizes handling in adYouLike adaptor #4013

Merged
merged 11 commits into from
Aug 11, 2019
Merged

Multiple sizes handling in adYouLike adaptor #4013

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
32adbfc
Merge remote-tracking branch 'origin/master'
guiann May 29, 2019
140b538
Remove useless bidderCode in bid response
guiann May 29, 2019
1bd5a3a
Merge remote-tracking branch 'guiann-prebid/master'
guiann May 29, 2019
613824c
Merge remote-tracking branch 'origin/master'
guiann Jun 13, 2019
8fb7857
Merge remote-tracking branch 'origin/master'
guiann Jul 18, 2019
21734b3
Merge branch 'master' into adYouLike-handleMultipleSizes
guiann Jul 18, 2019
e4a5f63
send all the available sizes in the bid request
guiann Jul 22, 2019
111dc49
Merge branch 'adYouLike-handleMultipleSizes'
guiann Jul 22, 2019
908eaab
Merge remote-tracking branch 'origin/master'
guiann Jul 22, 2019
edf4cd3
Use the banner sizes if given
guiann Jul 25, 2019
008ded4
avoid compatibility issue with old bid format
guiann Jul 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions modules/adyoulikeBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export const spec = {
* @return boolean True if this is a valid bid, and false otherwise.
*/
isBidRequestValid: function (bid) {
const sizes = getSize(bid.sizes);
const sizes = getSize(getSizeArray(bid));
if (!bid.params || !bid.params.placement || !sizes.width || !sizes.height) {
return false;
}
Expand All @@ -34,12 +34,14 @@ export const spec = {
const payload = {
Version: VERSION,
Bids: bidRequests.reduce((accumulator, bid) => {
let size = getSize(bid.sizes);
let sizesArray = getSizeArray(bid);
let size = getSize(sizesArray);
accumulator[bid.bidId] = {};
accumulator[bid.bidId].PlacementID = bid.params.placement;
accumulator[bid.bidId].TransactionID = bid.transactionId;
accumulator[bid.bidId].Width = size.width;
accumulator[bid.bidId].Height = size.height;
accumulator[bid.bidId].AvaiableSizes = sizesArray.join(',');
return accumulator;
}, {}),
PageRefreshed: getPageRefreshed()
Expand Down Expand Up @@ -156,10 +158,20 @@ function createEndpointQS(bidderRequest) {
return qs;
}

function getSizeArray(bid) {
let inputSize = bid.sizes;
if (bid.mediaTypes && bid.mediaTypes.banner) {
inputSize = bid.mediaTypes.banner.sizes;
}

return utils.parseSizesInput(inputSize);
}

/* Get parsed size from request size */
function getSize(requestSizes) {
function getSize(sizesArray) {
const parsed = {};
const size = utils.parseSizesInput(requestSizes)[0];
// the main requested size is the first one
const size = sizesArray[0];

if (typeof size !== 'string') {
return parsed;
Expand Down