Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ucfunnel support tdid #3977

Merged
merged 32 commits into from
Jul 31, 2019
Merged

ucfunnel support tdid #3977

merged 32 commits into from
Jul 31, 2019

Conversation

ucfunnel
Copy link
Contributor

@ucfunnel ucfunnel commented Jul 9, 2019

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

root and others added 30 commits June 5, 2017 05:43
2. Replace var with let
3. Put JSON.parse(JSON.stringify()) into try catch block
Merge the latest changes 9/25/2017
@mike-chowla mike-chowla self-assigned this Jul 9, 2019
@mike-chowla mike-chowla self-requested a review July 9, 2019 17:09
Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle CI tests are failing:
/home/circleci/Prebid.js/modules/ucfunnelBidAdapter.js
171:9 error Identifier 'userId_tdid' is not in camel case camelcase

@ucfunnel
Copy link
Contributor Author

ucfunnel commented Jul 11, 2019

I update the commit to fix Circle CI tests failed problem. What we can do next to move this forward?
@mike-chowla

Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike-chowla mike-chowla merged commit 918305f into prebid:master Jul 31, 2019
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
* ucfunnel tdid support
leonardlabat pushed a commit to criteo-forks/Prebid.js that referenced this pull request Aug 6, 2019
* ucfunnel tdid support
sa1omon pushed a commit to gamoshi/Prebid.js that referenced this pull request Nov 28, 2019
* ucfunnel tdid support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants