update karma and webpack-stream packages to address vulnerabilities #3966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaiminpanchal27
approved these changes
Jul 11, 2019
Fawke
added
the
needs 2nd review
robertrmartinez
approved these changes
Jul 15, 2019
1 task
jsnellbaker
added a commit
that referenced
this pull request
Jul 16, 2019
This reverts commit 6399ab1.
jsnellbaker
added a commit
that referenced
this pull request
Jul 16, 2019
leonardlabat
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
Jul 30, 2019
leonardlabat
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
Jul 30, 2019
2 tasks
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
sa1omon
pushed a commit
to gamoshi/Prebid.js
that referenced
this pull request
Nov 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Update the
karmaandwebpack-streampackages to address vulnerability in packagebraces, a nested dependency used by both the packages. The details of vulnerability can be found here.Since the fix involves a major version upgrade (
karma,v3.1.4->v4.1.0&webpack-stream,v3.2.0->v5.2.1), it can be a potentially breaking change. Hence, care has been taken to make sure,gulp serve,gulp testandgulp buildcommands are working as expected.