Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMX Digital: Device info and Video parameter updates #3929

Merged
merged 5 commits into from
Jun 24, 2019

Conversation

EMXDigital
Copy link
Contributor

Type of change

  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)

Description of change

Include device & cur, catches for adm decode, include mediaType video params, and styling updates.

@EMXDigital
Copy link
Contributor Author

We are not sure why this test is failing when submitting this PR. All tests pass when we run locally, please advise.

@jsnellbaker jsnellbaker self-requested a review June 20, 2019 12:46
@jsnellbaker jsnellbaker self-assigned this Jun 20, 2019
@mkendall07
Copy link
Member

This pull request introduces 1 alert when merging 6e86a03 into ce095e0 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @EMXDigital

I took a look through the updates. They largely seem good, though there are some items that need to be addressed. I saw you were making some changes already, so you may already be working on it.

Please let me know if you have any questions. Thanks!

secure: networkProtocol
tagid,
secure,
...(bidfloor > 0 && { bidfloor, bidfloorcur: DEFAULT_CUR })
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the spread operator like this isn't currently supported (this is what was causing the circleci browserstack test to fail during the original submission; spread is not supported in IE). Can you please refactor this part of the code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing this out -- we've pushed a refactor in our latest commit.

let emxImps = [];
const timeout = config.getConfig('bidderTimeout');
const emxImps = [];
const timeout = bidderRequest.timeout || "";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use single-quotes instead double-quotes. This will fix the lint error.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done -- thank you

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EMXDigital Thanks for making the updates; LGTM.

@jsnellbaker jsnellbaker merged commit 37232c7 into prebid:master Jun 24, 2019
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
* EMX Digital - device info and video parameter updates

* update timeout value to grab from bidderRequest arg

* removing unused import

* removing object spread use. quote fix for lint

* remove space
sa1omon pushed a commit to gamoshi/Prebid.js that referenced this pull request Nov 28, 2019
* EMX Digital - device info and video parameter updates

* update timeout value to grab from bidderRequest arg

* removing unused import

* removing object spread use. quote fix for lint

* remove space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants