Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #3908 #3923

Closed
wants to merge 1 commit into from
Closed

Fix for #3908 #3923

wants to merge 1 commit into from

Conversation

jaiminpanchal27
Copy link
Collaborator

Type of change

  • Build related changes

Description of change

Fix for #3908
Recently many use cases have come across where we needed submodules for prebid. Example include

  • user id module and various id systems
  • long form module and supported long form ad servers
    Also in future we would like to add other features as modules and not part of core.

Until we have a new build system and fresh approach to modules this PR fixes #3908.

This fix returns the modules which are included in module.json or as command line arguments to gulp.src.

Command 1: gulp build --modules=appnexusBidAdapter,digiTrustIdSystem --analyze
Result
Screen Shot 2019-06-18 at 2 48 01 PM

Command 1: gulp build --analyze
Result
Screen Shot 2019-06-18 at 2 51 03 PM

Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're putting the fix in the wrong place; we need to fix the webpack process. this partially fixes it: #3924

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

userID and adpod modules being included in prebid-core
2 participants