topRTBBidAdapter #3817

Unnamalai57 · 2019-05-10T12:40:01Z

New Bidder Adapter - topRTBBidAdapter

                bidder: 'topRTB',
                params: {
                    adUnitId: cd95dffec6b645afbc4e5aa9f68f2ff3
                }

Contact email of the adapter’s maintainer
[email protected]

robertrmartinez · 2019-05-18T04:36:35Z

@Unnamalai57 Hi! I am taking a look now.

Please update your test which is failing in Circle CI?

robertrmartinez · 2019-05-22T03:10:33Z

@Unnamalai57 Hello, just a reminder to please fix the failing tests.

Will re-review once complete.

robertrmartinez · 2019-05-23T13:48:37Z

If you would like this merged into the next Prebid Release, please make the changes to fix your failing tests.

Unnamalai57 · 2019-05-28T04:47:19Z

If you would like this merged into the next Prebid Release, please make the changes to fix your failing tests.

@robertrmartinez may I know what are the tests have been failed in topRTBBidAdapter?

robertrmartinez · 2019-05-28T04:52:21Z

You can see it says "Some checks were not successful" and you can click details which will take you to this link:
https://circleci.com/gh/prebid/Prebid.js/2537?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

robertrmartinez · 2019-05-28T04:53:36Z

robertrmartinez · 2019-05-28T04:57:47Z

I attempted to rerun them again, and they still fail
https://circleci.com/gh/prebid/Prebid.js/2568

sorry. Please try and fix when possible.

Unnamalai57 · 2019-05-28T05:21:38Z

I attempted to rerun them again, and they still fail
https://circleci.com/gh/prebid/Prebid.js/2568

sorry. Please try and fix when possible.

ok sure @robertrmartinez .Let me fix it

Unnamalai57 · 2019-05-28T08:45:52Z

@robertrmartinez I have fixed the test failing issue. Could you please verify it?

robertrmartinez

Please see comments and respond with questions or fixes

robertrmartinez · 2019-05-29T15:47:27Z

modules/topRTBBidAdapter.js

@@ -0,0 +1,70 @@
+import * as utils from '../src/utils';


Your test coverage is just barely at 80%

Would love to see those numbers jump up more soon. Will not reject PR for this, but please try to increase coverage on future PR's!

@robertrmartinez could you please tell me how can I enhance the testing to achieve 100%

robertrmartinez · 2019-05-29T15:48:48Z

modules/topRTBBidAdapter.js

+import {BANNER, VIDEO} from '../src/mediaTypes';
+
+const BIDDER_CODE = 'topRTB';
+const ENDPOINT_URL = 'http://ssp.toprtb.com:8080/sspNew/rest/ReqAd?ref=www.google.com&hbid=0&adUnitId=';


All adapters must support HTTPS

Plus I am not sure having port numbers in the endpoint is something we allow either.

Please address this.

Hi you still do not support HTTPS which is a requirement for prebid.js adapters.

Hi @robertrmartinez
SSL configuration is in progress. Will update as soon as completed

modules/topRTBBidAdapter.js

modules/topRTBBidAdapter.md

modules/topRTBBidAdapter.js

Unnamalai57 · 2019-06-06T10:28:07Z

@robertrmartinez I have just removed console log from topRTBAdapter.js. May I know in what case testing failed in CircleCI

robertrmartinez · 2019-06-12T20:55:03Z

modules/topRTBBidAdapter.js

+import {BANNER, VIDEO} from '../src/mediaTypes';
+
+const BIDDER_CODE = 'topRTB';
+const ENDPOINT_URL = 'http://ssp.toprtb.com:8080/sspNew/rest/ReqAd?ref=www.google.com&hbid=0&adUnitId=';


Hi you still do not support HTTPS which is a requirement for prebid.js adapters.

stale · 2019-07-03T08:44:27Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Unnamalai57 · 2019-07-06T04:34:38Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Still checking with SSL configurations. Will complete it

stale · 2019-07-20T04:45:29Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

bretg · 2019-07-22T23:37:04Z

@Unnamalai57 - any progress on this?

Unnamalai57 · 2019-07-26T05:21:37Z

@Unnamalai57 - any progress on this?

Hi @bretg
code has been committed with the updation of SSL

bretg · 2019-07-28T03:01:13Z

Great - back to @robertrmartinez

robertrmartinez · 2019-07-30T17:19:01Z

Thank you for the updates @Unnamalai57

I am still unable to get a valid bid response using the example you provided.

A bidders params should be reliable and always return a valid bid response.

Is there something in particular that I need to do to have your endpoint return a test bid?

Unnamalai57 · 2019-07-31T04:52:36Z

Thank you for the updates @Unnamalai57

I am still unable to get a valid bid response using the example you provided.

A bidders params should be reliable and always return a valid bid response.

Is there something in particular that I need to do to have your endpoint return a test bid?

Hi @robertrmartinez
I will give you the adunitId which gives the valid bid Response. Because the given adunit doesn't contain ad.

robertrmartinez

Thank you, glad to finally get this in! :)

* toprtbBidAdapter * topRTB adapter hbid queryparam added * toprtbBidAdapter-ssp aws url * topRTBBidAdapter * Video format topRTBBidAdapter * Video format topRTBBidAdapter * deviceType added * tracking new added * impression event added * fix test failed * fix testing failed * removed debug logs * added single quotes in adUnitId * remove console log * code committed to add SSL * adunitId changes for valid response

djaxtechgit added 5 commits March 29, 2019 13:42

toprtbBidAdapter

befda7e

topRTB adapter hbid queryparam added

478fbc7

toprtbBidAdapter-ssp aws url

8d7fe98

topRTBBidAdapter

cc620a4

Video format topRTBBidAdapter

024b10a

jsnellbaker requested a review from robertrmartinez May 13, 2019 13:00

jsnellbaker assigned robertrmartinez May 13, 2019

jsnellbaker added the needs review label May 13, 2019

djaxtechgit and others added 3 commits May 14, 2019 17:38

Video format topRTBBidAdapter

a82e0a0

deviceType added

8e48efa

tracking new added

be63d8a

impression event added

b8392d2

Unnamalai57 added 2 commits May 28, 2019 13:24

fix test failed

227bb38

fix testing failed

8e12dc6

robertrmartinez requested changes May 29, 2019

View reviewed changes

Unnamalai57 added 3 commits June 3, 2019 11:06

removed debug logs

306b0aa

added single quotes in adUnitId

a5832e8

remove console log

c89ab55

robertrmartinez requested changes Jun 12, 2019

View reviewed changes

stale bot added the stale label Jul 3, 2019

stale bot removed the stale label Jul 6, 2019

stale bot added the stale label Jul 20, 2019

bretg removed the stale label Jul 22, 2019

code committed to add SSL

99134d9

adunitId changes for valid response

5c36ada

robertrmartinez approved these changes Aug 6, 2019

View reviewed changes

robertrmartinez merged commit 0183f23 into prebid:master Aug 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

topRTBBidAdapter #3817

topRTBBidAdapter #3817

Unnamalai57 commented May 10, 2019

robertrmartinez commented May 18, 2019

robertrmartinez commented May 22, 2019

robertrmartinez commented May 23, 2019

Unnamalai57 commented May 28, 2019

robertrmartinez commented May 28, 2019

robertrmartinez commented May 28, 2019

robertrmartinez commented May 28, 2019

Unnamalai57 commented May 28, 2019

Unnamalai57 commented May 28, 2019

robertrmartinez left a comment

robertrmartinez May 29, 2019

Unnamalai57 Jun 3, 2019

robertrmartinez May 29, 2019

robertrmartinez Jun 5, 2019

robertrmartinez Jun 12, 2019

Unnamalai57 Jun 19, 2019

Unnamalai57 commented Jun 6, 2019

robertrmartinez Jun 12, 2019

stale bot commented Jul 3, 2019

Unnamalai57 commented Jul 6, 2019

stale bot commented Jul 20, 2019

bretg commented Jul 22, 2019

Unnamalai57 commented Jul 26, 2019

bretg commented Jul 28, 2019

robertrmartinez commented Jul 30, 2019

Unnamalai57 commented Jul 31, 2019

robertrmartinez left a comment

topRTBBidAdapter #3817

topRTBBidAdapter #3817

Conversation

Unnamalai57 commented May 10, 2019

robertrmartinez commented May 18, 2019

robertrmartinez commented May 22, 2019

robertrmartinez commented May 23, 2019

Unnamalai57 commented May 28, 2019

robertrmartinez commented May 28, 2019

robertrmartinez commented May 28, 2019

robertrmartinez commented May 28, 2019

Unnamalai57 commented May 28, 2019

Unnamalai57 commented May 28, 2019

robertrmartinez left a comment

Choose a reason for hiding this comment

robertrmartinez May 29, 2019

Choose a reason for hiding this comment

Unnamalai57 Jun 3, 2019

Choose a reason for hiding this comment

robertrmartinez May 29, 2019

Choose a reason for hiding this comment

robertrmartinez Jun 5, 2019

Choose a reason for hiding this comment

robertrmartinez Jun 12, 2019

Choose a reason for hiding this comment

Unnamalai57 Jun 19, 2019

Choose a reason for hiding this comment

Unnamalai57 commented Jun 6, 2019

robertrmartinez Jun 12, 2019

Choose a reason for hiding this comment

stale bot commented Jul 3, 2019

Unnamalai57 commented Jul 6, 2019

stale bot commented Jul 20, 2019

bretg commented Jul 22, 2019

Unnamalai57 commented Jul 26, 2019

bretg commented Jul 28, 2019

robertrmartinez commented Jul 30, 2019

Unnamalai57 commented Jul 31, 2019

robertrmartinez left a comment

Choose a reason for hiding this comment