Google ad manager support for long-form video #3787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnellbaker
requested changes
May 8, 2019
There was a problem hiding this comment.
Hi @jaiminpanchal27
Please see in-line comments below.
Additionally, if we're setting up a common folder for the modules - could we look into moving the adpod module into that folder? It was designed with a similar purpose of being available to multiple adserverVideo sub-modules.
modules/common/videoAdserver.js
Outdated
| @@ -0,0 +1,141 @@ | |||
| /** | |||
| * This module adds Freewheel support for Video to Prebid. | |||
There was a problem hiding this comment.
Should we update this comment so it's more generic?
added 5 commits
July 2, 2019 14:38
# Conflicts: # modules/freeWheelAdserverVideo.js # test/spec/modules/freeWheelAdserverVideo_spec.js
jsnellbaker
approved these changes
Jul 17, 2019
leonardlabat
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
Jul 30, 2019
* gam support * update gam module to use submodules pattern * Fix unit tests * bug fix: do not add bid if it is rejected and revert gulphelpers
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
* gam support * update gam module to use submodules pattern * Fix unit tests * bug fix: do not add bid if it is rejected and revert gulphelpers
sa1omon
pushed a commit
to gamoshi/Prebid.js
that referenced
this pull request
Nov 28, 2019
* gam support * update gam module to use submodules pattern * Fix unit tests * bug fix: do not add bid if it is rejected and revert gulphelpers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge for now.
Type of change
Description of change
This PR adds google ad server support to long-from video. Please refer #3759 for more details
We will test this with ad server once we get access.