Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bidfloor to params object #3641

Merged
merged 23 commits into from
Mar 15, 2019
Merged

add bidfloor to params object #3641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
afdf755
initial orbidder version in personal github repo
hendrikiseke1979 Jan 9, 2019
ffc6f0b
use adUnits from orbidder_example.html
hendrikiseke1979 Jan 9, 2019
5c9a947
replace obsolete functions
hendrikiseke1979 Jan 10, 2019
06d127e
forgot to commit the test
hendrikiseke1979 Jan 10, 2019
8617515
check if bidderRequest object is available
hendrikiseke1979 Jan 10, 2019
8b5c884
try to fix weird safari/ie issue
hendrikiseke1979 Jan 10, 2019
4eace10
Merge remote-tracking branch 'upstream/master'
hendrikiseke1979 Jan 14, 2019
8d9dd6f
merge changes from upstream
hendrikiseke1979 Jan 16, 2019
699d05d
fetch changes from upstream
hendrikiseke1979 Jan 17, 2019
367b1a7
ebayK: add more params
hendrikiseke1979 Jan 18, 2019
cfe0911
update orbidderBidAdapter.md
hendrikiseke1979 Jan 18, 2019
4279c11
use spec.<function> instead of this.<function> for consistency reasons
hendrikiseke1979 Jan 21, 2019
5625d93
fetch changes from upstream
hendrikiseke1979 Jan 21, 2019
67dc263
Merge branch 'feature/RAAS-2676'
hendrikiseke1979 Jan 21, 2019
89fb80b
fetch changes from upstream
hendrikiseke1979 Jan 24, 2019
ab665e9
fetch changes from upstream
hendrikiseke1979 Jan 28, 2019
b91d68d
fetch changes from upstream
Feb 1, 2019
393b3fe
fetch changes from upstream
Feb 15, 2019
d0b0cbc
fetch changes from upstream
hendrikiseke1979 Mar 5, 2019
5967f6e
fetch changes from upstream
hendrikiseke1979 Mar 6, 2019
df95b81
fetch changes from upstream
hendrikiseke1979 Mar 13, 2019
6169ec7
fetch changes from upstream
Mar 15, 2019
b05496f
add bidfloor parameter to params object
Mar 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/orbidderBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export const spec = {
return !!(bid.sizes && bid.bidId && bid.params &&
(bid.params.accountId && (typeof bid.params.accountId === 'string')) &&
(bid.params.placementId && (typeof bid.params.placementId === 'string')) &&
((typeof bid.params.bidfloor === 'undefined') || (typeof bid.params.bidfloor === 'number')) &&
((typeof bid.params.keyValues === 'undefined') || (typeof bid.params.keyValues === 'object')));
},

Expand Down
15 changes: 15 additions & 0 deletions test/spec/modules/orbidderBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,21 @@ describe('orbidderBidAdapter', () => {
delete bidRequest.params;
expect(spec.isBidRequestValid(bidRequest)).to.equal(false);
});

it('accepts optional bidfloor', () => {
const bidRequest = deepClone(defaultBidRequest);
bidRequest.params.bidfloor = 123;
expect(spec.isBidRequestValid(bidRequest)).to.equal(true);

bidRequest.params.bidfloor = 1.23;
expect(spec.isBidRequestValid(bidRequest)).to.equal(true);
});

it('doesn\'t accept malformed bidfloor', () => {
const bidRequest = deepClone(defaultBidRequest);
bidRequest.params.bidfloor = 'another not usable string';
expect(spec.isBidRequestValid(bidRequest)).to.equal(false);
});
});

describe('buildRequests', () => {
Expand Down