Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow root configs when building with analytics #3539

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

matthewlane
Copy link
Collaborator

@matthewlane matthewlane commented Feb 7, 2019

Type of change

  • Build related changes

Description of change

Babel 6.x and 7.x load configuration files differently. This PR fixes an issue when building with --analytics caused by that difference by setting the babelrcRoots when that flag is invoked. This allows analytic packages included in the build to use their own babel configuration file.

Copy link
Member

@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jsnellbaker jsnellbaker merged commit ae14a6a into master Feb 12, 2019
jacekburys-quantcast pushed a commit to jacekburys-quantcast/Prebid.js that referenced this pull request May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants