Update removeAdUnit #3527
Merged
Update removeAdUnit #3527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deekshithraop
requested review from
mkendall07,
jaiminpanchal27 and
jsnellbaker
|
What's the use case here? |
|
modification of adUnits in single page applications. Eventually we should remove |
bretg
requested changes
Feb 7, 2019
bretg
approved these changes
Feb 7, 2019
mkendall07
requested changes
Feb 12, 2019
src/prebid.js
Outdated
| * Remove all adUnits from the $$PREBID_GLOBAL$$ configuration | ||
| * @alias module:pbjs.removeAllAdUnits | ||
| */ | ||
| $$PREBID_GLOBAL$$.removeAllAdUnits = function () { |
There was a problem hiding this comment.
hmmm should we make this removeAdUnits([adUnitCodeArray]) ? seems more flexible.
|
@mkendall07 made changes and updated description |
|
@bretg fyi we decided to not add an extra method here but instead reuse the existing one. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
pbjs.removeAdUnit()
updated removeAdUnit so that if it is invoked with no arguments it will remove all add units, and it will also accept an array argument of addUnitCodes and will only remove them.