New bid adapter for OPEN8

[aiichiro]

Type of change

• New bidder adapter

Description of change

• test parameters for validating bids

{
    bidder: 'open8',
    params: {
        slotKey: '2ae5a533'
    }
}

• contact email of the adapter’s maintainer: [email protected]
• official adapter submission

[jsnellbaker]

Hi @aiichiro

Thanks for submitting this new adapter.

When I was attempting to test both the banner/video outstream test placements - I encountered set of 404/CORS related errors. I copied the text below for reference:

GET http://as.vt.open8.com/v1/control/prebid?slot_key=2ae5a533&imp_id=3l94t3s93z0cigm5&bid_id=2e09c4f8338215& 404 (Not Found)

Access to XMLHttpRequest at 'http://as.vt.open8.com/v1/control/prebid?slot_key=2ae5a533&imp_id=3l94t3s93z0cigm5&bid_id=2e09c4f8338215&' from origin 'http://test.localhost:9999' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.

Can you please take a look to see what's amiss? If you need any additional details, please let me know. Thanks

[jsnellbaker]

Also - can you please put together a docs PR (here) for your bidder? You can refer to the other bidder files for reference.

[aiichiro]

@jsnellbaker Thank you for your review.
Sorry, our server is not available now because it is under development yet.
But we tested adapter in staging environment and it worked.

I think we should send PR after our server has been available.
I'm sorry to trouble you and I was wondering if you could check PR after it.
Should we close this PR?

Also we create a doc PR.
prebid/prebid.github.io#1142

Thanks

[jsnellbaker]

@aiichiro Thanks for clarifying. Do you have a rough ETA for when the server would be available for use? If it's in the relatively near-future, we could just keep this PR open for a bit. If it's longer, we can close for now and resubmit it later. Let me know either way. Thanks.

[aiichiro]

@jsnellbaker Thanks for checking.
Now our server get to be available for use.
I would appriciate it if you could check again.

By the way, our video is floating header overlay. so video size depends on window size.

Thanks

[jsnellbaker]

Hi @aiichiro
Thanks for making the changes. I tested both the outstream and banner ads again and they were delivering properly.

While testing, I did observe some warning/errors that were thrown in the browser's console log from both ads. These errors were caught in try/catch blocks so it didn't interfere with the page loading, but I wanted to bring them to your attention in case you wanted to add an extra check in your code in these areas to handle the situation when the fields aren't populated in a bid response (or to confirm that this is what you want).

I noted the two areas in the code that caused the warning/error below; please let me know what you think. Thanks.

[jsnellbaker]

Could add a check to verify the bannerAd.imps is populated before running the forEach.

[jsnellbaker]

Could add a check here to verify the nurl property is populated in the bid object.

[aiichiro]

@jsnellbaker Thanks for your review.
The code that you pointed out were problem exactly and I fixed it. Thank you.
�Could you check them?
Thanks

[jsnellbaker]

Thanks for the update; LGTM