Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openxoutstream adapter #3509

Merged
merged 11 commits into from
Feb 12, 2019
Merged

Update openxoutstream adapter #3509

merged 11 commits into from
Feb 12, 2019

Conversation

HolzAndrew
Copy link
Contributor

@HolzAndrew HolzAndrew commented Feb 4, 2019

Type of change

  • Other

Description of change

-updates some values of the query params
-removes hardcoded availability_zone in template response
-adds loader code to template response

@harquail @jasminenoack @MelodyLi2017

@HolzAndrew HolzAndrew changed the title Update openxoutstream to use some hardcoded values Update openxoutstream adapter Feb 4, 2019
modules/openxoutstreamBidAdapter.js Show resolved Hide resolved
modules/openxoutstreamBidAdapter.md Outdated Show resolved Hide resolved
@bretg bretg self-assigned this Feb 4, 2019
@bretg
Copy link
Collaborator

bretg commented Feb 5, 2019

@HolzAndrew - so let me see if I understand -- if a user specifies an AdUnit of size 300x250 and includes openxoutstream as an adapter, it will under the covers change the size to 400x300 and make the auction request to your backend.

The net result being that a request for 300x250 could end up returning a creative of a totally different size? This bid will get thrown out due to size mismatch.

If I'm understanding this correctly, you need to fix this behavior.

If 400x300 is the only size you support, that's fine, but you should avoid making auctions unless the AdUnit specifies that size. Should not be weighing down the browser with requests/responses that are going to get thrown out due to a size mismatch.

@harquail
Copy link

harquail commented Feb 6, 2019

@HolzAndrew - so let me see if I understand -- if a user specifies an AdUnit of size 300x250 and includes openxoutstream as an adapter, it will under the covers change the size to 400x300 and make the auction request to your backend.

The net result being that a request for 300x250 could end up returning a creative of a totally different size? This bid will get thrown out due to size mismatch.

If I'm understanding this correctly, you need to fix this behavior.

If 400x300 is the only size you support, that's fine, but you should avoid making auctions unless the AdUnit specifies that size. Should not be weighing down the browser with requests/responses that are going to get thrown out due to a size mismatch.

@HolzAndrew @bretg

My understanding is that the sizes are a reflection of OpenX’s demand, and will display within the size of the placement created by the publisher.

So in the situation you described — the openx-outstream adapter would make a request to OpenX for video demand up to that size (400x300). The Yieldmo format then dynamically resizes the video within the creative to fit within the ad unit size set up by the publisher (300x250 in this case).

@HolzAndrew
Copy link
Contributor Author

@HolzAndrew - so let me see if I understand -- if a user specifies an AdUnit of size 300x250 and includes openxoutstream as an adapter, it will under the covers change the size to 400x300 and make the auction request to your backend.
The net result being that a request for 300x250 could end up returning a creative of a totally different size? This bid will get thrown out due to size mismatch.
If I'm understanding this correctly, you need to fix this behavior.
If 400x300 is the only size you support, that's fine, but you should avoid making auctions unless the AdUnit specifies that size. Should not be weighing down the browser with requests/responses that are going to get thrown out due to a size mismatch.

@HolzAndrew @bretg

My understanding is that the sizes are a reflection of OpenX’s demand, and will display within the size of the placement created by the publisher.

So in the situation you described — the openx-outstream adapter would make a request to OpenX for video demand up to that size (400x300). The Yieldmo format then dynamically resizes the video within the creative to fit within the ad unit size set up by the publisher (300x250 in this case).

@harquail exactly, thats the gist (@bretg )

Copy link
Collaborator

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well.

@bretg
Copy link
Collaborator

bretg commented Feb 7, 2019

Will merge when @jasminenoack

@HolzAndrew
Copy link
Contributor Author

Will merge when @jasminenoack

@bretg thanks! she just approved

@bretg bretg merged commit a2a231d into prebid:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants