Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenX hardcoded bidder code for video bid responses bug #3483

Merged
merged 1 commit into from
Jan 30, 2019
Merged

OpenX hardcoded bidder code for video bid responses bug #3483

merged 1 commit into from
Jan 30, 2019

Conversation

deivydas
Copy link
Contributor

Type of change

  • Bugfix

Description of change

Hardcoded bidder code for video bid responses prevent bidderAlias feature to work for video ad units and because of this reason hardcoded value from video Bid Response was deleted.
This change was tested with a video sample page.

Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike-chowla mike-chowla merged commit fd31534 into prebid:master Jan 30, 2019
@deivydas deivydas deleted the openx_bidder_alias_bug_for_video branch February 12, 2019 10:40
jacekburys-quantcast pushed a commit to jacekburys-quantcast/Prebid.js that referenced this pull request May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants