Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readpeakBidAdapter to detect currency and device type correctly #3476

Merged
merged 7 commits into from
Jan 29, 2019

Conversation

kurrestahlberg
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

ReadPeak Bid Adapter did not detect currency or device type correctly. This PR fixes those issues.

@kurrestahlberg kurrestahlberg changed the title Update readpeakBidAdapter Fix readpeakBidAdapter to detect currency and device type correctly Jan 24, 2019
@jaiminpanchal27 jaiminpanchal27 self-assigned this Jan 28, 2019
@jaiminpanchal27 jaiminpanchal27 merged commit abf91a3 into prebid:master Jan 29, 2019
pedrolopezmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Mar 18, 2019
…rebid#3476)

* Update ReadPeak adapter

* Replace $$PREBID_GLOBAL$$.version with $prebid.version$

* Fix test

* Use utils.getTopWindowReferrer() instead of custom function

* Fix device type and currency outgoing request of ReadPeak Bid Adapter

* Update tests to check for language and currency for ReadPeakBidAdapter
jacekburys-quantcast pushed a commit to jacekburys-quantcast/Prebid.js that referenced this pull request May 15, 2019
…rebid#3476)

* Update ReadPeak adapter

* Replace $$PREBID_GLOBAL$$.version with $prebid.version$

* Fix test

* Use utils.getTopWindowReferrer() instead of custom function

* Fix device type and currency outgoing request of ReadPeak Bid Adapter

* Update tests to check for language and currency for ReadPeakBidAdapter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants