Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adkernel adapters - admarkup html wrapping removed #3432

Merged
merged 1 commit into from
Jan 23, 2019
Merged

Adkernel adapters - admarkup html wrapping removed #3432

merged 1 commit into from
Jan 23, 2019

Conversation

ckbo3hrk
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • Removed admarkup html wrapping to make it uniform
  • Removed deprecating functions usage

@ckbo3hrk ckbo3hrk changed the title Admarkup html wrapping removed Adkernel adapters: - admarkup html wrapping removed Jan 14, 2019
@ckbo3hrk ckbo3hrk changed the title Adkernel adapters: - admarkup html wrapping removed Adkernel adapters - admarkup html wrapping removed Jan 14, 2019
robertrmartinez
robertrmartinez approved these changes Jan 22, 2019
View reviewed changes
Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

@ckbo3hrk Just rebase it from master as there was a change last week which made the import paths relative instead, so I just want to be sure they are up to date.

@ckbo3hrk
Copy link
Contributor Author

@robertrmartinez updated

robertrmartinez
robertrmartinez approved these changes Jan 23, 2019
View reviewed changes
Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertrmartinez robertrmartinez merged commit 3cde995 into prebid:master Jan 23, 2019
pedrolopezmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Mar 18, 2019
@ckbo3hrk
admarkup html wrapping removed (prebid#3432)
e72dfee
@ckbo3hrk ckbo3hrk deleted the adk_html branch November 26, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertrmartinez robertrmartinez robertrmartinez approved these changes

Assignees

@robertrmartinez robertrmartinez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ckbo3hrk @robertrmartinez