Add bidfloor param to allow dynamic bid floor CPM #3431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkendall07
requested changes
Jan 18, 2019
package-lock.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "prebid.js", | |||
| "version": "1.36.0-pre", | |||
| "version": "1.37.0", | |||
There was a problem hiding this comment.
please drop the changes to package.lock
There was a problem hiding this comment.
Those changes have been reverted!
mkendall07
approved these changes
Jan 29, 2019
pedrolopezmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Mar 18, 2019
* Add bidfloor to params to allow dynamic bid floor CPM * polyfill Number.isFinite for IE11/Safari 8 * ADSS-538 Revert changes to package-lock.json
jacekburys-quantcast
pushed a commit
to jacekburys-quantcast/Prebid.js
that referenced
this pull request
May 15, 2019
* Add bidfloor to params to allow dynamic bid floor CPM * polyfill Number.isFinite for IE11/Safari 8 * ADSS-538 Revert changes to package-lock.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Adds support to allow user to specify a minimum bid floor price by adding an optional
bidfloorparam. Ifbidflooris not specified, it will default to the values that are specified when setting up a GumGum publisher account.