Consent module doublecall

[olafbuitelaar]

new PR for; #3371

[jsnellbaker]

@olafbuitelaar Can you fix the linting errors that were caught in the circleci check?

[olafbuitelaar]

@jsnellbaker done..all green now..shouldn't these formattings not being dealt with automatically?

[jsnellbaker]

@olafbuitelaar Thanks for making the updates. If your text editor has a plugin for eslint, it would be captured/handled while your writing the code the changes. Depending on the setup of that plugin, when you save the file - it would automatically fix the linting errors during that save action.

Otherwise you'd need to run a gulp command to run the linting check. You could use gulp lint directly, or you could run gulp test or gulp serve (if you were testing your changes locally) as both of those commands include the gulp lint as part of the sequence.

[olafbuitelaar]

@jsnellbaker i'm using VS Code with the eslint plugin..maybe something is broken, i'll check it out..maybe have a: gulp format command? just as the beauty of go?

[jsnellbaker]

@olafbuitelaar I did some initial investigating/testing on setting up an auto-fix type option with gulp-eslint. While there appears to be a flag to fix issues in the eslint config, it's only applicable to that gulp stream and it doesn't apply force an update to the original source files. It can port the files to a new place, but that's not what we really need.

If you have any ideas to make this work (or can get it working), we'd be happy to accept a PR and can review the implementation/changes.

In terms of this PR, it appears to be working fine.

[idettman]

I was going to recommend removing all format only changes for a cleaner diff, but if @jsnellbaker is good with it, its fine with me.

[olafbuitelaar]

@idettman thanks. @jsnellbaker just made a PR which appears to work for me.
As final note on this issue, i could imagine other modules might suffer from being double registered as listener, which probably isn't good in all cases.