Allow multiple media type rubcion bid w/ invalid video to go through as banner #3037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snapwich
force-pushed
the
rubicon-multiple-mediaType
branch
from
9322ec2
to
e49795c
Compare
idettman
approved these changes
Sep 12, 2018
ptomasroos
pushed a commit
to happypancake/Prebid.js
that referenced
this pull request
Sep 25, 2018
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
SublimeJeremy
pushed a commit
to SublimeSkinz/Prebid.js
that referenced
this pull request
Oct 1, 2018
1 task
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
pedrolopezmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Currently if a bid comes through rubicon with both video and banner mediaTypes but the video is missing the video block (
bid.params.video) a bad video request will be made. This changes the behavior so that the rubicon adapter will instead send a valid banner request./cc @bretg