Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/pre1.0 sizes support #2633

Merged
merged 4 commits into from
May 30, 2018
Merged

Feature/pre1.0 sizes support #2633

merged 4 commits into from
May 30, 2018

Conversation

korys
Copy link
Contributor

@korys korys commented May 28, 2018

Type of change

  • Feature

Description of change

Add support for pre 1.0 sizes style

  • test parameters for validating bids
var adUnits = [
    {
        code: 'test-banner',
        mediaType: 'banner',
        sizes: [300, 250],
        bids: [
        {
            bidder: "ccx",
            params: {
            placementId: 3286844
            }
        }
        ]
    }

korys added 4 commits May 18, 2018 14:46
@korys
added ccxAdapter
4d9452c
@korys
add ccxAdapter - lint formatting fixes
67ae135
@korys
pre 1.0 sizes support
451e644
@korys
Merge branch 'master' into feature/pre1.0_sizes_support
2ca75cb 
# Conflicts:
#	modules/ccxBidAdapter.js
#	modules/ccxBidAdapter.md
#	test/spec/modules/ccxBidAdapter_spec.js
@snapwich snapwich self-requested a review May 30, 2018 17:12
snapwich
snapwich approved these changes May 30, 2018
View reviewed changes
Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snapwich snapwich merged commit 931c4ed into prebid:master May 30, 2018
Pupis pushed a commit to adform/Prebid.js that referenced this pull request Jun 7, 2018
@korys @Pupis
Feature/pre1.0 sizes support for ccx bid adapter (prebid#2633)
f7ee8fb 
* added ccxAdapter

* add ccxAdapter - lint formatting fixes

* pre 1.0 sizes support
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
@korys @dluxemburg
Feature/pre1.0 sizes support for ccx bid adapter (prebid#2633)
f9e4c8a 
* added ccxAdapter

* add ccxAdapter - lint formatting fixes

* pre 1.0 sizes support
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
@korys
Feature/pre1.0 sizes support for ccx bid adapter (prebid#2633)
46ba727 
* added ccxAdapter

* add ccxAdapter - lint formatting fixes

* pre 1.0 sizes support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snapwich snapwich snapwich approved these changes

Assignees

@snapwich snapwich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@korys @snapwich