Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add banner support to Beachfront adapter #2117

Merged
merged 20 commits into from
Mar 6, 2018

Conversation

jsalis
Copy link
Contributor

@jsalis jsalis commented Feb 7, 2018

Type of change

  • Feature
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

Description of change

Adds banner support to Beachfront Adapter.

  • test parameters for validating bids
{
  bidder: 'beachfront',
  params: {
    bidfloor: 0.01,
    appId: '3b16770b-17af-4d22-daff-9606bdf2c9c3'
  }
}

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

prebid/prebid.github.io#600

@mkendall07 mkendall07 added this to the Prebid 1.5.0 milestone Feb 23, 2018
@idettman idettman added LGTM and removed needs review labels Mar 6, 2018
@matthewlane matthewlane merged commit ae341f9 into prebid:master Mar 6, 2018
@jsalis jsalis deleted the beachfront-banner-support branch March 6, 2018 21:44
mizmaar3 added a commit to widespace-os/Prebid.js that referenced this pull request Mar 8, 2018
* master: (27 commits)
  Increment pre version
  Prebid 1.5.0 Release
  Fix cross-platform test failures (prebid#2228)
  Fix uncahced video bids from multi-response array triggering callback early (prebid#2219)
  Add vuble adapter (prebid#2201)
  Update Vidazoo domain (prebid#2223)
  InSkin Bid Adapter: remove referrer field from request body (prebid#2217)
  Gamma Support UserSync Endpoint (prebid#2216)
  Feature/stale bot (prebid#2192)
  33Across Bid Adapter: updated user sync endpoint (prebid#2193)
  Adding PR_REVIEW guideline (prebid#2159)
  Add FairTrade Bid Adapter (prebid#2147)
  Add banner support to Beachfront adapter (prebid#2117)
  Smartyads Adapter 1.x (prebid#2080)
  Audience Network: allow native bids for non-IAB sizes (prebid#2203)
  Update position default value in rubicon (prebid#2214)
  Auctionmanager spec refactor pr (prebid#2155)
  fix mediaType being overwritten by undefined in rubicon bid adapter (prebid#2209)
  Fix lint error (prebid#2208)
  VAST support in adform adapter (prebid#2173)
  ...
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
* Update Beachfront adapter for v1.0

* Revert Beachfront test endpoint

* Add Beachfront markdown file

* Add mediaTypes to example

* Fix formatting

* Remove descriptionUrl from bid response

* Add banner support to Beachfront adapter

* Fix bid response validation

* Update display endpoint

* Update display request and response to support multiple bids

* Remove console log

* Added display example to doc

* Add support for dnt

* add os version to bid request

* Use size from bid response

* Add secure to bid request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants