fix log message not displaying when referencing missing bidder #1737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would love a unit test... |
|
@robertrmartinez found this one. Just added a unit test. |
jaiminpanchal27
requested changes
Oct 20, 2017
test/spec/unit/pbjs_api_spec.js
Outdated
| @@ -779,6 +779,24 @@ describe('Unit: Prebid Module', function () { | |||
| adaptermanager.callBids.restore(); | |||
| }); | |||
|
|
|||
| it('should log an error if a bidder is used that does not exist', () => { | |||
There was a problem hiding this comment.
This test should go in adapterManager_spec. You can use adaptermanager.callBids function to test.
#1508 has some good arguments to avoid
Also stubs should be in beforeEach loop because if this test fails to avoid logError wont be restored.
snapwich
force-pushed
the
log-missing-adapter
branch
from
6cee170 to
6072219
Compare
|
updated |
jaiminpanchal27
approved these changes
Oct 21, 2017
Millerrok
pushed a commit
to Vertamedia/Prebid.js
that referenced
this pull request
Oct 25, 2017
* 'master' of https://github.com/prebid/Prebid.js: (414 commits) Make response headers available to the specs (prebid#1748) add option to run tests in a specific file (prebid#1727) Update JCM Adapter to 1.0 (prebid#1715) Finished an unfinished comment. (prebid#1749) Platform.io Bidder Adapter update. Prebid v1.0. (prebid#1705) Fix window.top.host cross origin issue when in nested iframes. (prebid#1730) fix log message not displaying when referencing missing bidder (prebid#1737) Allow more than one placement from one page (prebid#1692) Justpremium Adapter bugfix (prebid#1716) Updating license (prebid#1717) realvuBidAdapter (prebid#1571) Update JSDoc to call the module `pbjs` (prebid#1572) Update Beachfront adapter for v1.0 (prebid#1675) Update AdButler adapter for Prebid v1.0 (prebid#1664) Increment pre version Fix for prebid#1628 (allowing standard bidCpmAdjustment) (prebid#1645) Prebid 0.31.0 Release Support native click tracking (prebid#1691) Initial commit for video support for pbs (prebid#1706) Fixes: Immediate adapter response may end auction (prebid#1690) ...
mattpr
pushed a commit
to mattpr/Prebid.js
that referenced
this pull request
Oct 31, 2017
…d#1737) * fix log message not displaying when referencing missing bidder * add test for missing bidder log message * move test to adaptermanager_spec
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
…d#1737) * fix log message not displaying when referencing missing bidder * add test for missing bidder log message * move test to adaptermanager_spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Fixes small bug introduced with #1690 that makes error message never display when referencing a missing adapter.