PubMatic adapter #1707
PubMatic adapter #1707
Conversation
also added a new method createContentToExecuteExtScriptInFriendlyFrame in util
|
hey @pm-harshad-mane ... we're not accepting any pre-1.0 adapter PRs anymore. For more info, see how to add a Prebid 1.0 Bidder Adapter. In particular, you'll need to use AJAX rather than JSONP, and go through the bidderFactory. See the AppNexusAst adapter (if you can request all the bids using a single request) or Rubicon adapter (if you need multiple requests to request all the bids) for examples |
modules/pubmaticBidAdapter.js
Outdated
|
|
||
| /** | ||
| * Adapter for requesting bids from Pubmatic. | ||
| * | ||
| * @returns {{callBids: _callBids}} | ||
| * @constructor | ||
| */ | ||
| function PubmaticAdapter() { | ||
| var PubmaticAdapter = function PubmaticAdapter() { |
modules/pubmaticBidAdapter.js
Outdated
| var _pm_pub_gender; | ||
| var _pm_pub_kvs; | ||
| var _pm_optimize_adslots = []; | ||
| var usersync = false; |
|
|
||
| // istanbul ignore else | ||
| if (conf.pubId && slots.length > 0) { | ||
| _legacyExecution(conf, slots); |
There was a problem hiding this comment.
it looks like the legacy path is currently the only supported path (ie it still uses an iframe) is that correct? Is this optimized vs the last version?
There was a problem hiding this comment.
Our older implementation used to include an external js library, now we do not include it.
_legacyExecution is the only flow available now, we are planning to add a new flow later.
|
|
||
| function _legacyExecution(conf, slots) { | ||
| var url = _generateLegacyCall(conf, slots); |
There was a problem hiding this comment.
I'm not clear why this is still loaded into an iframe. Can you not use the ajax method here?
There was a problem hiding this comment.
Our server response uses global namespace also our server is not supporting CORS.
By calling our server from a friendly-iframe we can get better priority than calling from a script tag thus we are calling our server using an iframe.
|
Hello @mkendall07 , |
|
@pm-harshad-mane Noticed that there was an |
|
Hello @mkendall07 , I have updated test publishe ID (301) and adSlot (/15671365/DMDemo@728x90:0), now you can see the response, you might need to try few times to get bid-responses. |
|
Thank you very much @mkendall07 👍 |
….33.0 to aolgithub-master * commit '3e9756098bb20ecbe0314f16eed5298c5675b24c': (32 commits) Wrapped content type in options object. Added partners ids. Added changelog entry. Prebid 0.33.0 Release Update AOL adapter for v1.0 (prebid#1693) Sovrn 1.0 compliance (prebid#1796) Platform.io Bidder Adapter update (prebid#1817) Drop non-video bidders from video ad units (prebid#1815) Update renderAd to replace ${AUCTION_PRICE} in adUrl (prebid#1795) Pulsepoint adapter: fixing bid rejection due to missing mandatory bid params. (prebid#1823) Remove require.ensure entirely (prebid#1816) Add custom keyword support for pbs bid adapter (prebid#1763) OpenX Video Adapter update to Prebid v1.0 (prebid#1724) Fix test that hard-coded pbjs global. (prebid#1786) Update Pollux Adapter to v1.0 (prebid#1694) PubMatic adapter (prebid#1707) Added sizes to Rubicon Adapter (prebid#1818) jsonpFunction name should match the namespace (prebid#1785) Adding 33Across adapter (prebid#1805) Unit test fix (prebid#1812) ...
* Updated PubMatic adapter also added a new method createContentToExecuteExtScriptInFriendlyFrame in util * added a missing syntax * comment changed * Reviewe suggestions implemented
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
Other information