Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no longer attaching gpt slots to adUnits, which breaks utils.cloneJso… #1676

Merged
merged 1 commit into from
Oct 12, 2017
Merged

no longer attaching gpt slots to adUnits, which breaks utils.cloneJso… #1676

merged 1 commit into from
Oct 12, 2017

Conversation

harpere
Copy link
Collaborator

@harpere harpere commented Oct 11, 2017

in adaptermanager, utils.cloneJson(adUnit) fails when using the express.js lib because gpt slots are attached to the adUnits.

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

Other information

@snapwich snapwich self-requested a review October 12, 2017 18:43
snapwich
snapwich approved these changes Oct 12, 2017
View reviewed changes
Copy link
Collaborator

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snapwich snapwich merged commit f40f0e3 into prebid:master Oct 12, 2017
@snapwich snapwich deleted the improvement/express-gpt-slots branch October 12, 2017 18:44
outoftime pushed a commit to Genius/Prebid.js that referenced this pull request Oct 18, 2017
Merge tag '0.31.0' of https://github.com/prebid/Prebid.js into prebuilt
67b5f38 
* tag '0.31.0' of https://github.com/prebid/Prebid.js: (54 commits)
  Fix for prebid#1628 (allowing standard bidCpmAdjustment) (prebid#1645)
  Prebid 0.31.0 Release
  Support native click tracking (prebid#1691)
  Initial commit for video support for pbs (prebid#1706)
  Fixes: Immediate adapter response may end auction (prebid#1690)
  Rubicon feature/s2s test module (prebid#1678)
  Renaming of "huddledmasses" adapter into colossusssp (prebid#1701)
  Don't set non-object configurations (prebid#1704)
  Update JSDoc for `pbjs.enableAnalytics` (prebid#1565)
  Add ad units event (prebid#1702)
  AppnexusAst adapter: logging error message from endpoint (prebid#1697)
  AppnexusAst bidadapter markdown file (prebid#1696)
  Change Default Content-Type for POST Requests to 'application/json' (prebid#1681)
  Code improvement for trustx adapter (prebid#1673)
  PulsePoint Lite adapter - Enabling Sync pixel (prebid#1686)
  Update spotx video adapter to set the spotx_ad_key used in DFP (prebid#1614)
  Fix broken AOL mobile endpoint secure bid requests (prebid#1684)
  Fix adapter tests that hardcoded pbjs. (prebid#1666)
  no longer attaching gpt slots to adUnits, which breaks utils.cloneJson(adUnit) (prebid#1676)
  remove bidmanager from rubicon tests (prebid#1671)
  ...
rachelrj pushed a commit to sovrn/Prebid.js that referenced this pull request Oct 20, 2017
@harpere
no longer attaching gpt slots to adUnits, which breaks utils.cloneJso…
73b6f43 
…n(adUnit) (prebid#1676)
vzhukovsky added a commit to aol/Prebid.js that referenced this pull request Oct 30, 2017
@vzhukovsky
Merge pull request prebid#130 in AOLP_ADS_JS/prebid.js from release/1…
279bbae 
….31.0 to aolgithub-master

* commit 'e7341c948014a789084849495171d08d4b353d07': (21 commits)
  Added changelog entry.
  Fix for prebid#1628 (allowing standard bidCpmAdjustment) (prebid#1645)
  Prebid 0.31.0 Release
  Support native click tracking (prebid#1691)
  Initial commit for video support for pbs (prebid#1706)
  Fixes: Immediate adapter response may end auction (prebid#1690)
  Rubicon feature/s2s test module (prebid#1678)
  Renaming of "huddledmasses" adapter into colossusssp (prebid#1701)
  Don't set non-object configurations (prebid#1704)
  Update JSDoc for `pbjs.enableAnalytics` (prebid#1565)
  Add ad units event (prebid#1702)
  AppnexusAst adapter: logging error message from endpoint (prebid#1697)
  AppnexusAst bidadapter markdown file (prebid#1696)
  Change Default Content-Type for POST Requests to 'application/json' (prebid#1681)
  Code improvement for trustx adapter (prebid#1673)
  PulsePoint Lite adapter - Enabling Sync pixel (prebid#1686)
  Update spotx video adapter to set the spotx_ad_key used in DFP (prebid#1614)
  Fix broken AOL mobile endpoint secure bid requests (prebid#1684)
  Fix adapter tests that hardcoded pbjs. (prebid#1666)
  no longer attaching gpt slots to adUnits, which breaks utils.cloneJson(adUnit) (prebid#1676)
  ...
mattpr pushed a commit to mattpr/Prebid.js that referenced this pull request Oct 31, 2017
@harpere @mattpr
no longer attaching gpt slots to adUnits, which breaks utils.cloneJso…
4d8c636 
…n(adUnit) (prebid#1676)
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
@harpere @dluxemburg
no longer attaching gpt slots to adUnits, which breaks utils.cloneJso…
314a1d8 
…n(adUnit) (prebid#1676)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snapwich snapwich snapwich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harpere @snapwich