PulsePoint Lite adpater changes #1630
Conversation
* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: cleanup * ET-1691: minor * ET-1691: revert package.json change
ET-1850: Fixing #866
modules/pulsepointLiteBidAdapter.js
Outdated
| !!(bid && bid.params && bid.params.cp && bid.params.ct) | ||
| ), | ||
|
|
||
| buildRequests: bidRequest => { |
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks for pointing this out Anand. Opened a PR (prebid/prebid.github.io#380) on prebid.org to correct the docs. @snapwich will submit a PR to clarify the comments in the code.
Note that we also opted to rename the first parameter because there're actually two params formerly called "bidRequests" and "bidderRequest". This was kinda confusing, so we renamed the first to "validBidRequests". The second param isn't documented on prebid.org as it's expected to be needed only in rare cases, but is documented in the code.
There was a problem hiding this comment.
Thanks for clarifying @bretg
| import adaptermanager from 'src/adaptermanager'; | ||
| import { registerBidder } from 'src/adapters/bidderFactory'; | ||
|
|
||
| const NATIVE_DEFAULTS = { |
There was a problem hiding this comment.
These could go into native.js if they are per the spec (i think they are).
Doesn't need to change for merge though.
| /** | ||
| * Attempts to capture the referrer url. | ||
| */ | ||
| function referrer() { |
There was a problem hiding this comment.
this should also be a generic function (todo for utils).
….30.0 to aolgithub-master * commit '5a8d2bf93ee15071a78e24ac976103cacf3c6021': (35 commits) Added changelog entry. Prebid 0.30.1 Release Remove undefined variable usage (prebid#1662) fixes bug for IE when invalid value passed to parse (prebid#1657) Aliasbidder fix (prebid#1652) prebidAdapter secure support (prebid#1655) Increment pre version Prebid 0.30.0 Release Add native param support to mediaTypes (prebid#1625) PulsePoint Lite adpater changes (prebid#1630) Appnexus ast unittest updates (prebid#1654) Support aspect ratio specification for native images (prebid#1634) Revert changes for switch between client side and server side. (prebid#1653) rubicon converted to bidderFactory (prebid#1624) Add JSDoc for `pbjs.getAllWinningBids` (prebid#1566) Add ignore-loader to handle .md files (prebid#1646) fixed PBS cookie syncs (prebid#1637) Add placementId request param to Yieldmo bid adapter (prebid#1632) Adxcg analytics adapter (prebid#1599) Add publisher sub-id support to the Criteo adapter (prebid#1629) ...
Type of change
Description of change
Updates to the adapter to prepare for 1.0 upgrade.
Support for InApp parameters.
Test Page: http://projects.contextweb.com/av/prebid/1.0-pre/