Updates to PubWise Analytics - Enable config, UTM & Debug/Logging Upd… #1409

GLStephen · 2017-07-23T17:35:57Z

Type of change

This is an update to PubWise.io Analytics Adapter to support UTM parameters and improve loading when enableAnalytics is called in all supported places.

New Features

UTM Tracking

PubWise analytics now tracks UTM parameters and allows segments to be built on campaign in the PubWise UI, this is the foundation for additional functionality in the "Pro" version of PubWise analytics that will allow advanced segmentation

Updates

Refactoring to improve behavior related to configuration and "enableAnalytics" call.
Improvement to client side debugging capabilities, standardization of log prepend to filter console
Improvement to how configuration is handled
bump to 2.2

…ates

GLStephen · 2017-07-23T17:50:13Z

@matthewlane @protonate @mkendall07 Not to be pushy, but if this could make it into a 0.26.x patch that is upcoming I would be grateful and I can send cookies and cupcakes. Either way, appreciate it!

GLStephen · 2017-07-26T13:39:36Z

Merge conflicts have been resolved. The "default" url will have a valid response in the next 24-48 hours when the API endpoint is updated. I also fixed up the ESLint errors.

…eAnalyticsUpdate22

…js into pubwiseAnalyticsUpdate22

jaiminpanchal27

@GLStephen Added some comments.
I tried to enable analytics with hello_world test page.

pbjs.enableAnalytics({
          provider: 'pubwise',
          options: {
            site: 'test-test-test-test',
            endpoint: 'https://api.pubwise.io/api/v4/event/default/',
          }
        });

But getting 404 on your endpoint.

jaiminpanchal27 · 2017-07-26T16:25:54Z

modules/pubwiseAnalyticsAdapter.js

+let pwAnalyticsEnabled = false;
+let utmKeys = {'utm_source': '', 'utm_medium': '', 'utm_campaign': '', 'utm_term': '', 'utm_content': ''};
+
+let getParameterByName = function (name) {


This function is already defined in utils. Use that one.

jaiminpanchal27 · 2017-07-26T16:28:08Z

modules/pubwiseAnalyticsAdapter.js

+}
+
+function sendEvent(eventType, data) {
+  utils.logInfo(analyticsName + 'Event ' + eventType + ' ' + pwAnalyticsEnabled, data);


Use backticks here and other places in this file.

Hey, I think you misunderstood me. I meant use template literals.
Check here https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals

e.g: utils.logWarn(`Test string ${variable}.`);

jaiminpanchal27 · 2017-07-26T16:30:41Z

modules/pubwiseAnalyticsAdapter.js

+function enrichWithMetrics(dataBag) {
+  try {
+    dataBag['pw_version'] = pubwiseVersion;
+    dataBag['pbjs_version'] = pbjs.version;


Use $$PREBID_GLOBAL$$ here.

GLStephen · 2017-07-26T20:57:46Z

@jaiminpanchal27 I took another look and getParameterByName is not exported and is not used anywhere else currently

jaiminpanchal27 · 2017-07-26T21:08:33Z

Oops.. Sorry for that. I will update utils and let you know. Also i replied to you on the backtick change.

GLStephen · 2017-07-26T21:14:42Z

@jaiminpanchal27 I pushed up a version with the required Utils change. If that will block us from getting into the next release then I'd rather duplicate the function. If you want me to pull your change later I can do that too. However, as it stands for the adpater to work I had to include that change in my update.

Also, the staging "default" API endpoint will be updated and this can be released with that endpoint 404ing. I've added valid test config data to the analytics adapter header comments. That config will work. The "default" endpoint is a "canary" for us to detect misconfigured sites. In our next update it will have info about how to fix the endpoint config, etc. Just have to deal with releases being out of phase.

This line was added in prebid#1409, removing this then I'll merge

@jaiminpanchal27

* Added PolluxNetwork Bid Adapter Added module, test spec and integration example for Pollux Network Bid Adapter * Update Pollux domain Update Pollux default domain on prebid adapter * Export getParameterByName method On Utils.js make getParameterByName method public * Executed changes requested by @jaiminpanchal27 on 2017-08-01 Moved zone_728x90.html to integrationExamples/gpt/pollux_zone_728x90.html; Added bidRequest as second parameter to bidfactory.createBid() on Pollux Bid Adapter; Added more test cases to increase test coverage (at least 85%); Review Ref: - #1431 (review) * Fixed Eslint errors on commit f745fe1 * Executed changes requested on PR#1431 review #54993573 - Removed $$PREBID_GLOBAL$$ public vars in unit test; - Moved stubs creation and its restoration to beforeEach and afterEach hooks in unit test; - Exposed polluxHandler method on polluxBidAdapter. * Remove redundant export This line was added in #1409, removing this then I'll merge

prebid#1409) * Updates to Build Process to Support Building DIST and DEV Together * Updates to PubWise Analytics - Enable config, UTM & Debug/Logging Updates * Fixing ESLint Errors * Updates for ESLint which is now properly installed * Proper ESLint Fix Commit without Erroneous Files * File Cleanup * Additional File Cleanup to get Back to Upstream Master * Updates for Comments from jaiminpanchal27 * Adding by in ParameterByName * Updates w/ Utils

@jaiminpanchal27

* Added PolluxNetwork Bid Adapter Added module, test spec and integration example for Pollux Network Bid Adapter * Update Pollux domain Update Pollux default domain on prebid adapter * Export getParameterByName method On Utils.js make getParameterByName method public * Executed changes requested by @jaiminpanchal27 on 2017-08-01 Moved zone_728x90.html to integrationExamples/gpt/pollux_zone_728x90.html; Added bidRequest as second parameter to bidfactory.createBid() on Pollux Bid Adapter; Added more test cases to increase test coverage (at least 85%); Review Ref: - prebid#1431 (review) * Fixed Eslint errors on commit f745fe1 * Executed changes requested on PR#1431 review #54993573 - Removed $$PREBID_GLOBAL$$ public vars in unit test; - Moved stubs creation and its restoration to beforeEach and afterEach hooks in unit test; - Exposed polluxHandler method on polluxBidAdapter. * Remove redundant export This line was added in prebid#1409, removing this then I'll merge

@jaiminpanchal27

* Added PolluxNetwork Bid Adapter Added module, test spec and integration example for Pollux Network Bid Adapter * Update Pollux domain Update Pollux default domain on prebid adapter * Export getParameterByName method On Utils.js make getParameterByName method public * Executed changes requested by @jaiminpanchal27 on 2017-08-01 Moved zone_728x90.html to integrationExamples/gpt/pollux_zone_728x90.html; Added bidRequest as second parameter to bidfactory.createBid() on Pollux Bid Adapter; Added more test cases to increase test coverage (at least 85%); Review Ref: - #1431 (review) * Fixed Eslint errors on commit f745fe1 * Executed changes requested on PR#1431 review #54993573 - Removed $$PREBID_GLOBAL$$ public vars in unit test; - Moved stubs creation and its restoration to beforeEach and afterEach hooks in unit test; - Exposed polluxHandler method on polluxBidAdapter. * Remove redundant export This line was added in #1409, removing this then I'll merge * Update Pollux Adapter to v1.0 * Changes requested on Pollux Adapter pull request #1694 review #74933409 * Changes requested on Pollux Adapter pull request #1694 review #75505070 Rmoved parameter bidderCode from bid responses * Fixed breaking changes to serverResponse in interpretResponse method Parameter serverResponse of method interpretResponse in bid adapter changed from array of bids to an object, where bids are now nested within its parameter body. Plus a refactor of var declaration and log messages. * Fix lint errors on push for commit cc653a

GLStephen added 2 commits July 20, 2017 18:55

Updates to Build Process to Support Building DIST and DEV Together

2fc81d1

Updates to PubWise Analytics - Enable config, UTM & Debug/Logging Upd…

70f9a4e

…ates

jaiminpanchal27 self-assigned this Jul 25, 2017

Update for Merge Confilct

b963d1b

GLStephen added 7 commits July 26, 2017 13:48

Fixing ESLint Errors

6b11636

Merge branch 'pubbuild26' of github.com:PubWise/Prebid.js into pubwis…

bb0b6a0

…eAnalyticsUpdate22

Updates for ESLint which is now properly installed

ab6b095

Proper ESLint Fix Commit without Erroneous Files

883d7a3

Merge branch 'pubwiseAnalyticsUpdate22' of github.com:PubWise/Prebid.…

f8658be

…js into pubwiseAnalyticsUpdate22

File Cleanup

b07891d

Additional File Cleanup to get Back to Upstream Master

23a8dbe

jaiminpanchal27 requested changes Jul 26, 2017

View reviewed changes

jaiminpanchal27 added the needs update label Jul 26, 2017

GLStephen added 2 commits July 26, 2017 19:39

Updates for Comments from jaiminpanchal27

a716e07

Adding by in ParameterByName

a716dcc

Updates w/ Utils

ef32439

jaiminpanchal27 approved these changes Jul 28, 2017

View reviewed changes

jaiminpanchal27 added LGTM and removed needs update labels Jul 28, 2017

jaiminpanchal27 requested a review from matthewlane August 2, 2017 16:25

jaiminpanchal27 assigned matthewlane Aug 2, 2017

matthewlane approved these changes Aug 2, 2017

View reviewed changes

matthewlane merged commit 9475431 into prebid:master Aug 2, 2017

matthewlane added a commit to polluxnetwork/Prebid.js that referenced this pull request Aug 15, 2017

Remove redundant export

1d3ef09

This line was added in prebid#1409, removing this then I'll merge

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates to PubWise Analytics - Enable config, UTM & Debug/Logging Upd… #1409

Updates to PubWise Analytics - Enable config, UTM & Debug/Logging Upd… #1409

GLStephen commented Jul 23, 2017 •

edited

Loading

GLStephen commented Jul 23, 2017

GLStephen commented Jul 26, 2017 •

edited

Loading

jaiminpanchal27 left a comment

jaiminpanchal27 Jul 26, 2017

GLStephen Jul 26, 2017

jaiminpanchal27 Jul 26, 2017

GLStephen Jul 26, 2017

jaiminpanchal27 Jul 26, 2017

jaiminpanchal27 Jul 26, 2017

GLStephen Jul 26, 2017

GLStephen commented Jul 26, 2017

jaiminpanchal27 commented Jul 26, 2017

GLStephen commented Jul 26, 2017 •

edited

Loading

Updates to PubWise Analytics - Enable config, UTM & Debug/Logging Upd… #1409

Updates to PubWise Analytics - Enable config, UTM & Debug/Logging Upd… #1409

Conversation

GLStephen commented Jul 23, 2017 • edited Loading

Type of change

New Features

UTM Tracking

Updates

GLStephen commented Jul 23, 2017

GLStephen commented Jul 26, 2017 • edited Loading

jaiminpanchal27 left a comment

Choose a reason for hiding this comment

jaiminpanchal27 Jul 26, 2017

Choose a reason for hiding this comment

GLStephen Jul 26, 2017

Choose a reason for hiding this comment

jaiminpanchal27 Jul 26, 2017

Choose a reason for hiding this comment

GLStephen Jul 26, 2017

Choose a reason for hiding this comment

jaiminpanchal27 Jul 26, 2017

Choose a reason for hiding this comment

jaiminpanchal27 Jul 26, 2017

Choose a reason for hiding this comment

GLStephen Jul 26, 2017

Choose a reason for hiding this comment

GLStephen commented Jul 26, 2017

jaiminpanchal27 commented Jul 26, 2017

GLStephen commented Jul 26, 2017 • edited Loading

GLStephen commented Jul 23, 2017 •

edited

Loading

GLStephen commented Jul 26, 2017 •

edited

Loading

GLStephen commented Jul 26, 2017 •

edited

Loading