Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PulsePoint Lite adapter changes #1338

Merged
merged 17 commits into from
Jul 13, 2017
Merged

PulsePoint Lite adapter changes #1338

merged 17 commits into from
Jul 13, 2017

Conversation

anand-venkatraman
Copy link
Contributor

Type of change

  • Bugfix
  • Feature

Description of change

  1. Support for OpenRTB single request, in place of the current multi-request non-OpenRTB scheme.
  2. Support for Native (with bug-fix for Native impression tracker rendering).
  3. Fixing adapter name, with a new Alias "pulseLite". The previous name "pulsepointLite" had 14 characters and resulted in DFP key truncation (when sending all bids to DFP), due to the 20-char limit that DFP places.

Test page with the changes is here

Copy link
Collaborator

@matthewlane matthewlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the update

@matthewlane matthewlane merged commit fe00cc9 into prebid:master Jul 13, 2017
@snapwich
Copy link
Collaborator

adaptermanager.aliasBidAdapter('pulseLite', 'pulsepointLite');

Aliasing currently requires a createNew method on the adapters, which this adapter doesn't provide right now. This needs to be fixed.

@anand-venkatraman
Copy link
Contributor Author

@snapwich, this is addressed here - #1383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants