-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PubMatic Bid Adapter : support for InBannerVideo (IBV) Field in Bid Response with meta.mediaType #12484
Merged
pm-harshad-mane
merged 38 commits into
prebid:master
from
pm-nitin-shirsat:meta/UOE-11548
Nov 21, 2024
Merged
PubMatic Bid Adapter : support for InBannerVideo (IBV) Field in Bid Response with meta.mediaType #12484
pm-harshad-mane
merged 38 commits into
prebid:master
from
pm-nitin-shirsat:meta/UOE-11548
Nov 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync up prebid master to fork master
…bid-master # Conflicts: # modules/pubmaticBidAdapter.js # test/spec/modules/pubmaticBidAdapter_spec.js
Sync with prebid master
Merge pull request #5 from pm-nitin-shirsat/master
Sync with master
Sync with master
Sync with prebid master
Sync with Prebidd.js master
… plcmt parameter.
…lcmt parameter, if it is missing.
Sync with prebid master
Sync with master
Sync with master
Sync with master
Sync with master
Update master with latest
Sync with master
…deo when IBV is set to true
Sync with master
@pm-harshad-mane , @jlquaccia and @ChrisHuie - Can you please review the PR? Thank you! |
Sync with master
ChrisHuie
changed the title
PubMaticBidAdapter: Support for InBannerVideo (IBV) Field in Bid Response with meta.mediaType
PubMatic Bid Adapter : support for InBannerVideo (IBV) Field in Bid Response with meta.mediaType
Nov 21, 2024
ChrisHuie
approved these changes
Nov 21, 2024
pm-harshad-mane
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks @ChrisHuie !! |
Thank you @pm-harshad-mane & @ChrisHuie ! |
hogekai
pushed a commit
to hogekai/Prebid.js
that referenced
this pull request
Nov 21, 2024
…esponse with meta.mediaType (prebid#12484) Support for InBannerVideo (IBV) Field in Bid Response with meta.mediaType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Implementing functionality to consume and propagate the 'ibv' field from bid.ext to the bid response along with setting it meta.mediaType
Other information